Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2696613003: Make dartk-{release,debug} builders work properly again (Closed)

Created:
3 years, 10 months ago by kustermann
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make dartk-{release,debug} builders work properly again R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/d93928a6ce2015c0998ebdfcab231cea2e0fb70f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M tests/co19/co19-kernel.status View 4 chunks +3 lines, -4 lines 0 comments Download
M tests/language/language_kernel.status View 7 chunks +9 lines, -5 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M utils/kernel-service/kernel-service.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
3 years, 10 months ago (2017-02-14 12:19:41 UTC) #2
Vyacheslav Egorov (Google)
LGTM! Thanks for fixing it.
3 years, 10 months ago (2017-02-14 13:01:08 UTC) #3
kustermann
3 years, 10 months ago (2017-02-14 13:02:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d93928a6ce2015c0998ebdfcab231cea2e0fb70f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698