Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1947)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2696613003: Make dartk-{release,debug} builders work properly again (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/language_kernel.status ('k') | utils/kernel-service/kernel-service.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 0da9883dc884eae8f51ad17c752ac856cae3dd31..9a5eed82c44cb536e172aa92bb4a655c8929a81e 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -2339,15 +2339,18 @@ class BatchDFEProcess {
static Future<String> _firstLine(stream) {
var completer = new Completer<String>();
- var first = true;
stream.transform(UTF8.decoder)
.transform(new LineSplitter())
.listen((line) {
- if (first) {
+ if (!completer.isCompleted) {
completer.complete(line);
- first = false;
}
// We need to drain a pipe continuously.
+ }, onDone: () {
+ if (!completer.isCompleted) {
+ completer.completeError(
+ "DFE kernel compiler server did not sucessfully start up");
+ }
});
return completer.future;
}
@@ -2360,7 +2363,7 @@ class BatchDFEProcess {
_port = -1;
_process = await io.Process.start(executable, arguments);
_process.exitCode.then(_onExit);
- _process.stderr.drain();
+ _process.stderr.transform(UTF8.decoder).listen(DebugLogger.error);
final readyMsg = await _firstLine(_process.stdout);
final data = readyMsg.split(' ');
« no previous file with comments | « tests/language/language_kernel.status ('k') | utils/kernel-service/kernel-service.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698