Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2696563006: Add "auto" handling to border-image-width animations (Closed)

Created:
3 years, 10 months ago by alancutter (OOO until 2018)
Modified:
3 years, 10 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "auto" handling to border-image-width animations Animation code was not able to handle "auto" values in border-image-width keyframes. This patch adds it to the NonInterpolableValue along with appropriate handling for animating between values with matched auto keywords. BUG=681424 Review-Url: https://codereview.chromium.org/2696563006 Cr-Commit-Position: refs/heads/master@{#451550} Committed: https://chromium.googlesource.com/chromium/src/+/33adb63225089cac29c7973df63cac8dffb731d3

Patch Set 1 #

Patch Set 2 : default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -101 lines) Patch
M third_party/WebKit/LayoutTests/animations/interpolation/border-image-width-interpolation-expected.txt View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp View 1 15 chunks +138 lines, -93 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
alancutter (OOO until 2018)
3 years, 10 months ago (2017-02-14 04:56:27 UTC) #2
Eric Willigers
lgtm
3 years, 10 months ago (2017-02-16 05:07:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696563006/1
3 years, 10 months ago (2017-02-17 00:07:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/368385)
3 years, 10 months ago (2017-02-17 00:34:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696563006/20001
3 years, 10 months ago (2017-02-20 00:56:34 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 03:12:19 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/33adb63225089cac29c7973df63c...

Powered by Google App Engine
This is Rietveld 408576698