Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2696563003: [heap] Ensure consistency between store buffer mode and moving all entries to remembered set. (Closed)

Created:
3 years, 10 months ago by Hannes Payer (out of office)
Modified:
3 years, 10 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Ensure consistency between store buffer mode and moving all entries to remembered set. BUG=chromium:673308 Review-Url: https://codereview.chromium.org/2696563003 Cr-Commit-Position: refs/heads/master@{#43159} Committed: https://chromium.googlesource.com/v8/v8/+/866d5b2d3b2c972eda762514c889a3444938e449

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -9 lines) Patch
M src/heap/heap.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 4 chunks +17 lines, -2 lines 0 comments Download
M src/heap/store-buffer.h View 7 chunks +16 lines, -6 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
ulan
lgtm https://codereview.chromium.org/2696563003/diff/1/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/2696563003/diff/1/src/heap/heap.h#newcode1531 src/heap/heap.h:1531: class StoreBufferScope; As discussed offline let's call it ...
3 years, 10 months ago (2017-02-13 15:03:21 UTC) #4
Hannes Payer (out of office)
https://codereview.chromium.org/2696563003/diff/1/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/2696563003/diff/1/src/heap/heap.h#newcode1531 src/heap/heap.h:1531: class StoreBufferScope; On 2017/02/13 15:03:21, ulan (slow response travel) ...
3 years, 10 months ago (2017-02-13 15:14:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696563003/20001
3 years, 10 months ago (2017-02-13 15:16:23 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 15:41:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/866d5b2d3b2c972eda762514c889a344493...

Powered by Google App Engine
This is Rietveld 408576698