Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2696533002: Rmoving the notion of task runner from MediaStreamProvider interface. (Closed)

Created:
3 years, 10 months ago by o1ka
Modified:
3 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, audio-mojo-cl_google.com, Max Morin, ossu-chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rmoving the notion of task runner from MediaStreamProvider interface. AudioInputDeviceManager (which is MediaStreamProvider) does not require a task runner, since it gets one from AudioManager. So, removing that from the base class interface to simplify further refactoring of AudioInputDeviceManager. BUG=672468 Review-Url: https://codereview.chromium.org/2696533002 Cr-Commit-Position: refs/heads/master@{#450311} Committed: https://chromium.googlesource.com/chromium/src/+/e7803cf27acc67ddc9625e0fc3bfd18541786132

Patch Set 1 #

Messages

Total messages: 16 (10 generated)
o1ka
guidou@ - PTAL
3 years, 10 months ago (2017-02-13 13:07:31 UTC) #7
chfremer
I took a look at the changes to VideoCaptureManager since I have several refactoring CLs ...
3 years, 10 months ago (2017-02-13 19:18:38 UTC) #9
Guido Urdaneta
lgtm
3 years, 10 months ago (2017-02-14 10:08:53 UTC) #10
o1ka
On 2017/02/14 10:08:53, Guido Urdaneta wrote: > lgtm Thanks chfremer@ and guidou@!
3 years, 10 months ago (2017-02-14 10:16:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696533002/1
3 years, 10 months ago (2017-02-14 10:17:09 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 10:23:51 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7803cf27acc67ddc9625e0fc3bf...

Powered by Google App Engine
This is Rietveld 408576698