Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2058)

Unified Diff: chrome/browser/plugins/flash_download_interception_unittest.cc

Issue 2696493003: Introduce SubframeNavigationFilteringThrottle (Closed)
Patch Set: fix use after stack return, make code nicer Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/flash_download_interception_unittest.cc
diff --git a/chrome/browser/plugins/flash_download_interception_unittest.cc b/chrome/browser/plugins/flash_download_interception_unittest.cc
index ff89e7c145681ee2a4314d6c556c1e93952d76ad..b69cfbb41ac9ad12af8472088ca7e7543e90ca0b 100644
--- a/chrome/browser/plugins/flash_download_interception_unittest.cc
+++ b/chrome/browser/plugins/flash_download_interception_unittest.cc
@@ -90,8 +90,9 @@ TEST_F(FlashDownloadInterceptionTest, NavigationThrottleCancelsNavigation) {
NavigationHandle::CreateNavigationHandleForTesting(
GURL("https://get.adobe.com/flashplayer"), main_rfh());
- handle->CallWillStartRequestForTesting(true, content::Referrer(), true,
- ui::PAGE_TRANSITION_LINK, false);
+ handle->CallWillStartRequestForTesting(
+ true, content::Referrer(), true, ui::PAGE_TRANSITION_LINK, false,
+ content::NavigationHandle::ThrottleChecksFinishedCallback());
std::unique_ptr<NavigationThrottle> throttle =
FlashDownloadInterception::MaybeCreateThrottleFor(handle.get());
EXPECT_NE(nullptr, throttle);

Powered by Google App Engine
This is Rietveld 408576698