chrome/browser/extensions/extension_navigation_throttle_unittest.cc - Issue 2696493003: Introduce SubframeNavigationFilteringThrottle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_navigation_throttle_unittest.cc

Issue 2696493003: Introduce SubframeNavigationFilteringThrottle (Closed)

Patch Set: fix use after stack return, make code nicer Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/plugins/flash_download_interception_unittest.cc » ('j') | components/subresource_filter/content/browser/subframe_filtering_navigation_throttle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_navigation_throttle_unittest.cc

diff --git a/chrome/browser/extensions/extension_navigation_throttle_unittest.cc b/chrome/browser/extensions/extension_navigation_throttle_unittest.cc

index 10e3a001c798e0447b2e0b88471fc4c9a3c1abba..077453b6e10aafe05ab95ec2c3e5942cde8c4950 100644

--- a/chrome/browser/extensions/extension_navigation_throttle_unittest.cc

+++ b/chrome/browser/extensions/extension_navigation_throttle_unittest.cc

@@ -76,7 +76,8 @@ class ExtensionNavigationThrottleUnitTest

handle->CallWillStartRequestForTesting(

/*is_post=*/false, content::Referrer(),

/*has_user_gesture=*/false, ui::PAGE_TRANSITION_LINK,

- /*is_external_protocol=*/false))

+ /*is_external_protocol=*/false,

+ content::NavigationHandle::ThrottleChecksFinishedCallback()))

<< url;

}