gpu: Use mojom API for creating gpu channel.

gpu: Use mojom API for creating gpu channel.

chrome-gpu and chrome-browser already talk over the mojom API for some
things (e.g. initialization). Update these to use the mojom API for
creating a gpu channel too.

BUG=643746, 630895
Review-Url: https://codereview.chromium.org/2696473002
Cr-Commit-Position: refs/heads/master@{#450225}
Committed: https://chromium.googlesource.com/chromium/src/+/550e264fded00563fd094dfdf527b5073924432b

[sadrul, 2017-02-12 07:09:14]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 07:09:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-12 07:10:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 07:10:52]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sadrul, 2017-02-12 07:23:04]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 07:23:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-02-12 08:09:52]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 08:09:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-12 09:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 09:19:32]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-02-12 15:21:03]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 15:21:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-12 15:45:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 15:45:11]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[sadrul, 2017-02-13 06:30:02]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 06:30:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 07:18:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 07:18:40]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-02-13 15:42:43]

Description was changed from

==========
gpu: Use mojom API for creating gpu channel.

..

BUG=...
==========

to

==========
gpu: Use mojom API for creating gpu channel.

chrome-gpu and chrome-browser already talk over the mojom API for some
things (e.g. initialization). Update these to use the mojom API for
creating a gpu channel too.

BUG=643746, 630895
==========

[sadrul, 2017-02-13 15:45:39]

sadrul@chromium.org changed reviewers:
+ jbauman@chromium.org, tsepez@chromium.org

[sadrul, 2017-02-13 15:46:24]

tsepez@: Please review gpu_host_messages.h and gpu_service.mojom

jbauman@: Please review all

[Fady Samuel, 2017-02-13 15:52:26]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-02-13 15:52:27]

Drive-by question

https://codereview.chromium.org/2696473002/diff/80001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_process_host.cc (left):

https://codereview.chromium.org/2696473002/diff/80001/content/browser/gpu/gpu...
content/browser/gpu/gpu_process_host.cc:722: DVLOG(1) << "Failed to send
GpuMsg_EstablishChannel.";
What happens if the MessagePipe has a connection error?

[sadrul, 2017-02-13 15:57:23]

https://codereview.chromium.org/2696473002/diff/80001/content/browser/gpu/gpu...
File content/browser/gpu/gpu_process_host.cc (left):

https://codereview.chromium.org/2696473002/diff/80001/content/browser/gpu/gpu...
content/browser/gpu/gpu_process_host.cc:722: DVLOG(1) << "Failed to send
GpuMsg_EstablishChannel.";
On 2017/02/13 15:52:27, Fady Samuel wrote:
> What happens if the MessagePipe has a connection error?

That would be when the gpu process has crashed or dying. GpuProcessHost itself
is destroyed in that case, and triggers the callbacks stored in
|channel_requests_| (in SendOutstandingReplies()).

[Tom Sepez, 2017-02-13 18:00:22]

lgtm

[jbauman, 2017-02-14 03:26:06]

lgtm

[sadrul, 2017-02-14 03:38:33]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-02-14 03:39:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 03:45:03]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487043513584960,
"parent_rev": "561f3eacf7cc29fb1d8fe7d74b76fec1ec7ea7c8", "commit_rev":
"550e264fded00563fd094dfdf527b5073924432b"}

[commit-bot: I haz the power, 2017-02-14 03:45:42]

Description was changed from

==========
gpu: Use mojom API for creating gpu channel.

chrome-gpu and chrome-browser already talk over the mojom API for some
things (e.g. initialization). Update these to use the mojom API for
creating a gpu channel too.

BUG=643746, 630895
==========

to

==========
gpu: Use mojom API for creating gpu channel.

chrome-gpu and chrome-browser already talk over the mojom API for some
things (e.g. initialization). Update these to use the mojom API for
creating a gpu channel too.

BUG=643746, 630895

Review-Url: https://codereview.chromium.org/2696473002
Cr-Commit-Position: refs/heads/master@{#450225}
Committed:
https://chromium.googlesource.com/chromium/src/+/550e264fded00563fd094dfdf527...
==========

[commit-bot: I haz the power, 2017-02-14 03:45:43]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/550e264fded00563fd094dfdf527...