Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 2696403003: Fix unit_tests assert failure. (Closed)

Created:
3 years, 10 months ago by grt (UTC plus 2)
Modified:
3 years, 10 months ago
Reviewers:
Nico, Paweł Hajdan Jr.
CC:
chromium-reviews, Sorin Jianu, waffles
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unit_tests assert failure. Install a default InstallDetails instance for the test binary. BUG=373987, 692568 R=phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2696403003 Cr-Commit-Position: refs/heads/master@{#451315} Committed: https://chromium.googlesource.com/chromium/src/+/7a4e3a4e6fa17894c3a4cdc0f03ed3380fe468f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/test/base/run_all_unittests.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
grt (UTC plus 2)
3 years, 10 months ago (2017-02-16 14:52:07 UTC) #1
grt (UTC plus 2)
Hi Pawel. Please feel free to check the CQ box, as this is causing the ...
3 years, 10 months ago (2017-02-16 14:54:15 UTC) #4
Nico
rs-lgtm to get bots green. If this change is wrong for some reason, we can ...
3 years, 10 months ago (2017-02-17 15:33:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696403003/1
3 years, 10 months ago (2017-02-17 15:34:11 UTC) #10
Paweł Hajdan Jr.
LGTM
3 years, 10 months ago (2017-02-17 15:37:59 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 16:09:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7a4e3a4e6fa17894c3a4cdc0f03e...

Powered by Google App Engine
This is Rietveld 408576698