Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2696323003: Link to new web-platform-tests.org documentation from our own (Closed)

Created:
3 years, 10 months ago by foolip
Modified:
3 years, 10 months ago
Reviewers:
qyearsley, jeffcarp, pwnall
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Link to new web-platform-tests.org documentation from our own Many pages of testthewebforward.org now redirect, so replace links with something appropriate from the new documentation. Since the new documentation consistently says "web-platform-tests" instead of "Web Platform Tests" and this is what folks like jgraham tend to write as well, align our own usage with that. BUG=657117 Review-Url: https://codereview.chromium.org/2696323003 Cr-Commit-Position: refs/heads/master@{#451045} Committed: https://chromium.googlesource.com/chromium/src/+/eda32ab0041fe3ca8ba09b4ef89f02bf90754e30

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M docs/testing/layout_tests.md View 1 chunk +2 lines, -2 lines 0 comments Download
M docs/testing/layout_tests_tips.md View 2 chunks +2 lines, -2 lines 0 comments Download
M docs/testing/layout_tests_with_manual_fallback.md View 2 chunks +2 lines, -2 lines 0 comments Download
M docs/testing/web_platform_tests.md View 6 chunks +12 lines, -11 lines 0 comments Download
M docs/testing/writing_layout_tests.md View 5 chunks +15 lines, -16 lines 2 comments Download
M third_party/WebKit/Source/core/dom/custom/README.md View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
foolip
PTAL. I'm poking at a bunch of different documentation here, but it should suffice if ...
3 years, 10 months ago (2017-02-16 03:16:17 UTC) #4
qyearsley
LGTM -- and thanks for clarifying that "web-platform-tests" is the standard way of writing it. ...
3 years, 10 months ago (2017-02-16 17:00:32 UTC) #7
foolip
On 2017/02/16 17:00:32, qyearsley wrote: > LGTM -- and thanks for clarifying that "web-platform-tests" is ...
3 years, 10 months ago (2017-02-16 18:04:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696323003/1
3 years, 10 months ago (2017-02-16 18:04:59 UTC) #10
foolip
On 2017/02/16 18:04:07, foolip wrote: > On 2017/02/16 17:00:32, qyearsley wrote: > > LGTM -- ...
3 years, 10 months ago (2017-02-16 18:11:26 UTC) #11
pwnall
LGTM. I like the structure of the new site way better. I really like that ...
3 years, 10 months ago (2017-02-16 19:10:40 UTC) #12
foolip
https://codereview.chromium.org/2696323003/diff/1/docs/testing/writing_layout_tests.md File docs/testing/writing_layout_tests.md (right): https://codereview.chromium.org/2696323003/diff/1/docs/testing/writing_layout_tests.md#newcode17 docs/testing/writing_layout_tests.md:17: (WPT). This helps us avoid regressions, and helps us ...
3 years, 10 months ago (2017-02-16 19:18:59 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 19:22:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eda32ab0041fe3ca8ba09b4ef89f...

Powered by Google App Engine
This is Rietveld 408576698