Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2696303003: Add a script to GRIT to generate predetermined resource ids file. (Closed)

Created:
3 years, 10 months ago by Alexei Svitkine (slow)
Modified:
3 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a script to GRIT to generate predetermined resource ids file. This script will be used to produce a resource ordering file with the resources loaded during Chrome startup sequence that will be fed back into GRIT via the mechanism implemented by: https://codereview.chromium.org/2690263004/ Also adds a README.md about how to use it. BUG=692670 Review-Url: https://codereview.chromium.org/2696303003 Cr-Commit-Position: refs/heads/master@{#451458} Committed: https://chromium.googlesource.com/chromium/src/+/fe16437ea76d582b4a931e219cd452756e2c6498

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -0 lines) Patch
A tools/grit/grit/format/gen_predetermined_ids.py View 1 1 chunk +157 lines, -0 lines 0 comments Download
A tools/grit/grit/format/gen_predetermined_ids_unittest.py View 1 chunk +43 lines, -0 lines 0 comments Download
A tools/gritsettings/README.md View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Alexei Svitkine (slow)
3 years, 10 months ago (2017-02-17 15:33:32 UTC) #4
Nico
This one lgtm https://codereview.chromium.org/2696303003/diff/40001/tools/grit/grit/format/gen_predetermined_ids.py File tools/grit/grit/format/gen_predetermined_ids.py (right): https://codereview.chromium.org/2696303003/diff/40001/tools/grit/grit/format/gen_predetermined_ids.py#newcode8 tools/grit/grit/format/gen_predetermined_ids.py:8: input to grit via the -p ...
3 years, 10 months ago (2017-02-17 21:49:29 UTC) #7
Alexei Svitkine (slow)
https://codereview.chromium.org/2696303003/diff/40001/tools/grit/grit/format/gen_predetermined_ids.py File tools/grit/grit/format/gen_predetermined_ids.py (right): https://codereview.chromium.org/2696303003/diff/40001/tools/grit/grit/format/gen_predetermined_ids.py#newcode8 tools/grit/grit/format/gen_predetermined_ids.py:8: input to grit via the -p option. See tools/gritsettings/README.md ...
3 years, 10 months ago (2017-02-17 21:56:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696303003/80001
3 years, 10 months ago (2017-02-17 21:58:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-18 00:02:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696303003/80001
3 years, 10 months ago (2017-02-18 13:12:25 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 13:16:01 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fe16437ea76d582b4a931e219cd4...

Powered by Google App Engine
This is Rietveld 408576698