Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2696283003: Revert of Don't create layout objects for children of display-none iframes. (Closed)

Created:
3 years, 10 months ago by Matt Giuca
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, eae+blinkwatch, jam, kinuko+watch, mlamouri+watch-blink_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't create layout objects for children of display-none iframes. (patchset #31 id:650001 of https://codereview.chromium.org/2564633002/ ) Reason for revert: Suspect for webkit_tests leak failures (https://crbug.com/692872). See bug for details. Original issue's description: > Don't create layout objects for children of display-none iframes. > > Most of this CL is plumbing for FrameOwnerProperties. Interesting changes: > * LayoutView can no longer have children if its FrameOwner is "DisplayNone". > * A local frame is "DisplayNone" if and only if it has no widget [which should > correspond to the actual display:none style]. > * The DisplayNone property is propagated to remote frames via > FrameOwnerProperties. > > Spec discussion: https://github.com/whatwg/html/issues/1813 > > BUG=650433 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2564633002 > Cr-Commit-Position: refs/heads/master@{#450748} > Committed: https://chromium.googlesource.com/chromium/src/+/962434d34e2c9bcd17488f499515920c298b5395 TBR=esprehn@chromium.org,dcheng@chromium.org,avi@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=650433 Review-Url: https://codereview.chromium.org/2696283003 Cr-Commit-Position: refs/heads/master@{#450855} Committed: https://chromium.googlesource.com/chromium/src/+/d8b91eaadcd63c7ece9def5ed795b99256c8188a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1677 lines) Patch
M content/common/frame_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/frame_owner_properties.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/frame_owner_properties.cc View 2 chunks +3 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/display-none-iframe-has-no-animation.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/display-none-iframe-has-no-animation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/animations/resources/frame_with_animation.html View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/resources/common.js View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-block-to-display-none.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-block-to-display-none-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-none-to-display-block.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-none-to-display-block-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 2 chunks +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/iframe-display-block-to-display-none-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/iframe-display-block-to-display-none-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/iframe-display-none-to-display-block-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/iframe-display-none-to-display-block-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 2 chunks +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/iframe-display-block-to-display-none-expected.txt View 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt View 2 chunks +12 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/iframe-display-block-to-display-none-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/iframe-display-block-to-display-none-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/iframe-display-none-to-display-block-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/iframe-display-none-to-display-block-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/spinvalidation/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/stable/paint/invalidation/iframe-display-block-to-display-none-expected.txt View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/stable/paint/invalidation/iframe-display-none-to-display-block-expected.txt View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/stable/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/iframe-display-block-to-display-none-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/iframe-display-none-to-display-block-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/iframe-display-block-to-display-none-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/spinvalidation/paint/invalidation/iframe-display-none-to-display-block-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/paint/invalidation/iframe-display-block-to-display-none-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/paint/invalidation/iframe-display-none-to-display-block-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/iframe-display-block-to-display-none-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/spinvalidation/paint/invalidation/iframe-display-none-to-display-block-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/iframe-display-block-to-display-none-expected.txt View 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt View 2 chunks +12 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/iframe-display-block-to-display-none-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/iframe-display-none-to-display-block-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/spinvalidation/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/stable/paint/invalidation/iframe-display-block-to-display-none-expected.txt View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/stable/paint/invalidation/iframe-display-none-to-display-block-expected.txt View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/stable/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 1 chunk +0 lines, -121 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameOwner.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameElementBase.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp View 4 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 3 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 4 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameOwner.h View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameOwner.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrame.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 2 chunks +0 lines, -60 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameOwnerProperties.h View 4 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Matt Giuca
Created Revert of Don't create layout objects for children of display-none iframes.
3 years, 10 months ago (2017-02-16 03:03:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696283003/1
3 years, 10 months ago (2017-02-16 03:05:22 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 03:08:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8b91eaadcd63c7ece9def5ed795...

Powered by Google App Engine
This is Rietveld 408576698