Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 2696233003: [parser] Clear scope for inner block in function with complex parameters (Closed)

Created:
3 years, 10 months ago by adamk
Modified:
3 years, 10 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Clear scope for inner block in function with complex parameters The parser was finalizing the inner block scope, but not clearing the inner block's scope pointer. This doesn't (yet) have any behavioral difference, but makes it easier to make assumptions about the structure of the AST vs the scope chain. R=neis@chromium.org Review-Url: https://codereview.chromium.org/2696233003 Cr-Commit-Position: refs/heads/master@{#43233} Committed: https://chromium.googlesource.com/v8/v8/+/4e4a968e0eb2f86fc5bbbd9f7e5c7f98e5111732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/parsing/parser-base.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
adamk
3 years, 10 months ago (2017-02-15 19:58:13 UTC) #1
neis
lgtm
3 years, 10 months ago (2017-02-16 08:57:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696233003/1
3 years, 10 months ago (2017-02-16 08:57:31 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 08:59:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4e4a968e0eb2f86fc5bbbd9f7e5c7f98e51...

Powered by Google App Engine
This is Rietveld 408576698