Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 26962002: Remove unnamed namespace usage from tests. (Closed)

Created:
7 years, 2 months ago by tfarina
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove unnamed namespace usage from tests. Skia code prefers static over unnamed namespace. BUG=None TEST=None R=bsalomon@google.com,robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=11747

Patch Set 1 #

Total comments: 2

Patch Set 2 : revert the changes to DynamicHashTest.cpp #

Patch Set 3 : revert AreEqual change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -518 lines) Patch
M tests/DynamicHashTest.cpp View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M tests/FillPathTest.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M tests/FitsInTest.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M tests/GrMemoryPoolTest.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M tests/JpegTest.cpp View 1 chunk +390 lines, -393 lines 0 comments Download
M tests/LayerDrawLooperTest.cpp View 3 chunks +1 line, -4 lines 0 comments Download
M tests/OnceTest.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 4 chunks +2 lines, -7 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 11 chunks +17 lines, -22 lines 0 comments Download
M tests/TileGridTest.cpp View 4 chunks +0 lines, -4 lines 0 comments Download
M tests/WArrayTest.cpp View 1 chunk +44 lines, -48 lines 0 comments Download
M tests/WritePixelsTest.cpp View 13 chunks +21 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
7 years, 2 months ago (2013-10-11 01:39:21 UTC) #1
bsalomon
lgtm
7 years, 2 months ago (2013-10-11 14:18:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/26962002/1
7 years, 2 months ago (2013-10-11 14:18:28 UTC) #3
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildTests http://skiabot-master.pogerlabs.com:10117/buildstatus?builder=Build-Ubuntu12-GCC-x86_64-Release-Trybot&number=768
7 years, 2 months ago (2013-10-11 14:31:14 UTC) #4
bsalomon
https://codereview.chromium.org/26962002/diff/1/tests/DynamicHashTest.cpp File tests/DynamicHashTest.cpp (right): https://codereview.chromium.org/26962002/diff/1/tests/DynamicHashTest.cpp#newcode16 tests/DynamicHashTest.cpp:16: static const int& GetKey(const Entry& entry) { return entry.key; ...
7 years, 2 months ago (2013-10-11 14:46:40 UTC) #5
tfarina
https://codereview.chromium.org/26962002/diff/1/tests/DynamicHashTest.cpp File tests/DynamicHashTest.cpp (right): https://codereview.chromium.org/26962002/diff/1/tests/DynamicHashTest.cpp#newcode16 tests/DynamicHashTest.cpp:16: static const int& GetKey(const Entry& entry) { return entry.key; ...
7 years, 2 months ago (2013-10-11 23:47:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/26962002/19001
7 years, 2 months ago (2013-10-12 17:15:51 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-12 17:25:28 UTC) #8
Message was sent while issue was closed.
Change committed as 11747

Powered by Google App Engine
This is Rietveld 408576698