Remove unnamed namespace usage from tests.

tests/DynamicHashTest.cpp

+/*
+ * Copyright 2013 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
 #include "Test.h"
 #include "SkTDynamicHash.h"
 
-namespace {
-
 struct Entry {
     int key;
     double value;
 };
-const int& GetKey(const Entry& entry) { return entry.key; }
-uint32_t GetHash(const int& key) { return key; }
-bool AreEqual(const Entry& entry, const int& key) { return entry.key == key; }
 
+static const int& GetKey(const Entry& entry) { return entry.key; }

[bsalomon, 2013/10/11 14:46:41]

Hey Thiago, static functions cannot be used as template arguments (see below in
SkTDynamicHash). So this is a case where we actually have to use namespaces.

[tfarina, 2013/10/11 23:47:04]

Done.

+static uint32_t GetHash(const int& key) { return key; }
+static bool AreEqual(const Entry& entry, const int& key) {
+    return entry.key == key;
+}
 
 class Hash : public SkTDynamicHash<Entry, int, GetKey, GetHash, AreEqual> {
 public:
     Hash() : INHERITED() {}
     Hash(int capacity) : INHERITED(capacity) {}
 
     // Promote protected methods to public for this test.
     int capacity() const { return this->INHERITED::capacity(); }
     int countCollisions(const int& key) const { return this->INHERITED::countCollisions(key); }
 
 private:
     typedef SkTDynamicHash<Entry, int, GetKey, GetHash, AreEqual> INHERITED;
 };
 
-}  // namespace
-
 #define ASSERT(x) REPORTER_ASSERT(reporter, x)
 
 static void test_growth(skiatest::Reporter* reporter) {
     Entry a = { 1, 2.0 };
     Entry b = { 2, 3.0 };
     Entry c = { 3, 4.0 };
     Entry d = { 4, 5.0 };
     Entry e = { 5, 6.0 };
 
     Hash hash(4);
@@ skipping 94 matching lines @@
 
 static void test_dynamic_hash(skiatest::Reporter* reporter) {
     test_growth(reporter);
     test_add(reporter);
     test_lookup(reporter);
     test_remove(reporter);
 }
 
 #include "TestClassDef.h"
 DEFINE_TESTCLASS("DynamicHash", DynamicHashTestClass, test_dynamic_hash);