Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2696193002: Remove non-md code from tray_vpn.cc (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 10 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-md code from tray_vpn.cc BUG=686233 Review-Url: https://codereview.chromium.org/2696193002 Cr-Commit-Position: refs/heads/master@{#450851} Committed: https://chromium.googlesource.com/chromium/src/+/c4b0179113bfaf5389faae5c95a3ac21dbeeafd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M ash/common/system/chromeos/network/network_icon.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/network/network_icon.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M ash/common/system/chromeos/network/tray_vpn.cc View 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Evan Stade
3 years, 10 months ago (2017-02-15 22:16:04 UTC) #6
tdanderson
LGTM
3 years, 10 months ago (2017-02-15 23:53:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696193002/1
3 years, 10 months ago (2017-02-16 00:14:56 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 00:58:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c4b0179113bfaf5389faae5c95a3...

Powered by Google App Engine
This is Rietveld 408576698