Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2696173002: Fix receiver in Runtime::GetFrameDetails (Closed)

Created:
3 years, 10 months ago by jgruber
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] Handle OOM events in debugger tests Map OOM breaks generated by inspector to DebugEvent.OOM. This avoids generating unintentional DebugEvent.Break events. Also be more future-proof in event categorization. On a related note, this CL also fixes a DCHECK in Runtime::GetFrameDetails. The receiver needs to be grabbed from the inlined frame, not the outer optimized frame. Optimized frames only provide the receiver on a best-effort basis. BUG=v8:5950 Review-Url: https://codereview.chromium.org/2696173002 Cr-Commit-Position: refs/heads/master@{#43244} Committed: https://chromium.googlesource.com/v8/v8/+/e9f5e1e99ed6d5c4930700be848f205bb1758369

Patch Set 1 #

Patch Set 2 : Merge with OOM event #

Patch Set 3 : Disable receiver DCHECK for optimized frames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -8 lines) Patch
M src/runtime/runtime-debug.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M test/debugger/debugger.status View 1 1 chunk +0 lines, -4 lines 0 comments Download
A test/debugger/regress/regress-5950.js View 1 chunk +37 lines, -0 lines 0 comments Download
M test/debugger/test-api.js View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (18 generated)
jgruber
3 years, 10 months ago (2017-02-16 11:35:37 UTC) #16
Yang
On 2017/02/16 11:35:37, jgruber wrote: Awesome! Nice work investigating the cause. LGTM.
3 years, 10 months ago (2017-02-16 11:42:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696173002/40001
3 years, 10 months ago (2017-02-16 11:46:46 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 11:48:29 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/e9f5e1e99ed6d5c4930700be848f205bb17...

Powered by Google App Engine
This is Rietveld 408576698