Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2696143005:
DevTools: fix NavigatorView exception (Closed)
|
Created:
3 years, 10 months ago by lushnikov Modified:
3 years, 10 months ago Reviewers:
pfeldman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: fix NavigatorView exception
This patch fixes the "Cannot read property _deferredScrollIntoView of
undefined" exception in navigator view.
The navigator view assumes that there's only one project per frame; thus,
when the project gets removed, it removes frame.
However, in case of content script projects, there are multiple projects
per frame, so the logic is incorrect.
BUG=596053
R=pfeldman
Review-Url: https://codereview.chromium.org/2696143005
Cr-Commit-Position: refs/heads/master@{#452205}
Committed: https://chromium.googlesource.com/chromium/src/+/870b0bed803975d8ccd75a3af5ceff935214e2f5
Patch Set 1 #Patch Set 2 : add test #Patch Set 3 : move test to http #
Messages
Total messages: 31 (17 generated)
please, take a look
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
On 2017/02/16 02:56:16, lushnikov wrote: > please, take a look Could you explain why this helps? Also, a test?
lgtm, but please try adding a test
added a test! thanks!
The CQ bit was checked by lushnikov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/2696143005/#ps20001 (title: "add test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lushnikov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/2696143005/#ps40001 (title: "move test to http")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487792603788890,
"parent_rev": "bd45f79107360ff1c01bebc7d0097959a8e04f70", "commit_rev":
"870b0bed803975d8ccd75a3af5ceff935214e2f5"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: fix NavigatorView exception This patch fixes the "Cannot read property _deferredScrollIntoView of undefined" exception in navigator view. The navigator view assumes that there's only one project per frame; thus, when the project gets removed, it removes frame. However, in case of content script projects, there are multiple projects per frame, so the logic is incorrect. BUG=596053 R=pfeldman ========== to ========== DevTools: fix NavigatorView exception This patch fixes the "Cannot read property _deferredScrollIntoView of undefined" exception in navigator view. The navigator view assumes that there's only one project per frame; thus, when the project gets removed, it removes frame. However, in case of content script projects, there are multiple projects per frame, so the logic is incorrect. BUG=596053 R=pfeldman Review-Url: https://codereview.chromium.org/2696143005 Cr-Commit-Position: refs/heads/master@{#452205} Committed: https://chromium.googlesource.com/chromium/src/+/870b0bed803975d8ccd75a3af5ce... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/870b0bed803975d8ccd75a3af5ce... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
