ValueSerializer: Add SetTreatArrayBufferViewsAsHostObjects() flag

ValueSerializer: Add SetTreatArrayBufferViewsAsHostObjects() flag

Add `ValueSerializer::SetTreatArrayBufferViewsAsHostObjects()` which
instructs the `ValueSerializer` to treat ArrayBufferView objects as
host objects.

BUG=v8:5926
Review-Url: https://codereview.chromium.org/2696133007
Cr-Commit-Position: refs/heads/master@{#43281}
Committed: https://chromium.googlesource.com/v8/v8/+/3b15d950eeddcf6dba091b611e1a6cc100e2edd9

[Anna Henningsen, 2017-02-16 19:40:46]

addaleax@gmail.com changed reviewers:
+ jbroman@chromium.org

[Anna Henningsen, 2017-02-16 19:40:47]

This is basically the approach in
https://bugs.chromium.org/p/v8/issues/detail?id=5926#c3 worked out.

Tried to implement the semantics Node needs on top of it and that seems to work
out… I guess whether you want to go down this road or not is up to you?

Also, I feel like I got tagging reviewers right this time, but so far there has
always been *something* I screw up.

[jbroman, 2017-02-16 23:10:02]

jbroman@chromium.org changed reviewers:
+ jkummerow@chromium.org

[jbroman, 2017-02-16 23:10:03]

lgtm (but you'll need v8 owner review)

+jkummerow for v8 owners

https://codereview.chromium.org/2696133007/diff/1/test/unittests/value-serial...
File test/unittests/value-serializer-unittest.cc (right):

https://codereview.chromium.org/2696133007/diff/1/test/unittests/value-serial...
test/unittests/value-serializer-unittest.cc:2544: serializer_ = serializer;
nit: prefer to call the superclass method rather than duplicate it:

ValueSerializerTestWithHostObject::BeforeEncode(serializer);

https://codereview.chromium.org/2696133007/diff/1/test/unittests/value-serial...
test/unittests/value-serializer-unittest.cc:2551:
.WillOnce(Invoke([this](Isolate*, Local<Object> object) {
nit: EXPECT_TRUE(object->IsUint8Array());

Maybe also confirm that it has the right data, though that may be overkill.

https://codereview.chromium.org/2696133007/diff/1/test/unittests/value-serial...
test/unittests/value-serializer-unittest.cc:2558: return
NewHostObject(deserialization_context(), 0, nullptr);
nit: it's a little weird to produce an entirely different kind of object, even
though that is of course possible. Maybe produce a Uint8Array instead?

[Anna Henningsen, 2017-02-17 12:22:55]

Updated with nits addressed

https://codereview.chromium.org/2696133007/diff/1/test/unittests/value-serial...
File test/unittests/value-serializer-unittest.cc (right):

https://codereview.chromium.org/2696133007/diff/1/test/unittests/value-serial...
test/unittests/value-serializer-unittest.cc:2544: serializer_ = serializer;
On 2017/02/16 23:10:03, jbroman wrote:
> nit: prefer to call the superclass method rather than duplicate it:
> 
> ValueSerializerTestWithHostObject::BeforeEncode(serializer);

Done.

https://codereview.chromium.org/2696133007/diff/1/test/unittests/value-serial...
test/unittests/value-serializer-unittest.cc:2551:
.WillOnce(Invoke([this](Isolate*, Local<Object> object) {
On 2017/02/16 23:10:03, jbroman wrote:
> nit: EXPECT_TRUE(object->IsUint8Array());
> 
> Maybe also confirm that it has the right data, though that may be overkill.

Done, except for the second part... I can do that if you want but it might just
distract from the point here. :)

https://codereview.chromium.org/2696133007/diff/1/test/unittests/value-serial...
test/unittests/value-serializer-unittest.cc:2558: return
NewHostObject(deserialization_context(), 0, nullptr);
On 2017/02/16 23:10:03, jbroman wrote:
> nit: it's a little weird to produce an entirely different kind of object, even
> though that is of course possible. Maybe produce a Uint8Array instead?

Done.

[Jakob Kummerow, 2017-02-17 13:19:30]

lgtm

[Anna Henningsen, 2017-02-17 13:49:45]

The CQ bit was checked by addaleax@gmail.com

[Anna Henningsen, 2017-02-17 13:49:46]

The patchset sent to the CQ was uploaded after l-g-t-m from jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2696133007/#ps20001
(title: "ValueSerializer: Add SetTreatArrayBufferViewsAsHostObjects() flag")

[commit-bot: I haz the power, 2017-02-17 13:49:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 14:19:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487339385812390,
"parent_rev": "d91a7be50c3c823ea3e04d9240e6029101d2f45a", "commit_rev":
"3b15d950eeddcf6dba091b611e1a6cc100e2edd9"}

[commit-bot: I haz the power, 2017-02-17 14:19:44]

Description was changed from

==========
ValueSerializer: Add SetTreatArrayBufferViewsAsHostObjects() flag

Add `ValueSerializer::SetTreatArrayBufferViewsAsHostObjects()` which
instructs the `ValueSerializer` to treat ArrayBufferView objects as
host objects.

BUG=v8:5926
==========

to

==========
ValueSerializer: Add SetTreatArrayBufferViewsAsHostObjects() flag

Add `ValueSerializer::SetTreatArrayBufferViewsAsHostObjects()` which
instructs the `ValueSerializer` to treat ArrayBufferView objects as
host objects.

BUG=v8:5926

Review-Url: https://codereview.chromium.org/2696133007
Cr-Commit-Position: refs/heads/master@{#43281}
Committed:
https://chromium.googlesource.com/v8/v8/+/3b15d950eeddcf6dba091b611e1a6cc100e...
==========

[commit-bot: I haz the power, 2017-02-17 14:19:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/3b15d950eeddcf6dba091b611e1a6cc100e...