Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2696133002: Add performance tests of page up/down key navigation (Closed)

Created:
3 years, 10 months ago by yoichio
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add performance tests of page up/down key navigation Page up/down in textarea with lots of line w/o spellcheck is slow. These test creates a textarea w/o spellcheck and insert 20000 lines. Then, exec page up/down command at the bottom of the textarea. BUG=692379 Review-Url: https://codereview.chromium.org/2696133002 Cr-Commit-Position: refs/heads/master@{#450648} Committed: https://chromium.googlesource.com/chromium/src/+/2951b0dfa47f9b19c0ed36c383a0f131df0d23c3

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
A third_party/WebKit/PerformanceTests/Editing/page-down-with-many-lines.html View 1 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/PerformanceTests/Editing/page-up-with-many-lines.html View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
yoichio
3 years, 10 months ago (2017-02-15 07:38:24 UTC) #3
yosin_UTC9
lgtm Should we have spellcheck=true version? Are spellcheck=true and spellcheck=false different?
3 years, 10 months ago (2017-02-15 08:00:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696133002/20001
3 years, 10 months ago (2017-02-15 08:49:16 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 10:01:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2951b0dfa47f9b19c0ed36c383a0...

Powered by Google App Engine
This is Rietveld 408576698