Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2696083003: Convert drag-drop-url-with-style.html to utilize w3c test harness (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, chromium-reviews, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert drag-drop-url-with-style.html to utilize w3c test harness This patch converts "drag-drop-url-with-style.html" in "LayoutTests/editing/pasteboard" to utilize |assert_selection()| with w3c test harness to simplify test case and more readable for improving code helath. BUG=679977 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2696083003 Cr-Commit-Position: refs/heads/master@{#450675} Committed: https://chromium.googlesource.com/chromium/src/+/041393842d74fc93b1d2e8d0e5a66086f2f02892

Patch Set 1 : 2017-02-15T17:48:10 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -54 lines) Patch
M third_party/WebKit/LayoutTests/editing/pasteboard/drag-drop-url-with-style.html View 1 chunk +46 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/pasteboard/drag-drop-url-with-style-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
yosin_UTC9
PTAL This patch helps [1] to minimize test expectation changes. [1] http://crrev.com/2695193002 Selection API: setBaseAndExtent() ...
3 years, 10 months ago (2017-02-15 08:49:30 UTC) #5
tkent
lgtm
3 years, 10 months ago (2017-02-15 08:55:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696083003/1
3 years, 10 months ago (2017-02-15 09:36:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/390626)
3 years, 10 months ago (2017-02-15 10:44:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696083003/1
3 years, 10 months ago (2017-02-15 11:44:33 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 12:50:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/041393842d74fc93b1d2e8d0e5a6...

Powered by Google App Engine
This is Rietveld 408576698