Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2696013003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, media-router+watch_chromium.org, viettrungluu+watch_chromium.org, tfarina, dominickn+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2696013003 Cr-Commit-Position: refs/heads/master@{#451166} Committed: https://chromium.googlesource.com/chromium/src/+/3a6c5f97a4013fa27b9e5a47d71cee76c1513f35

Patch Set 1 #

Patch Set 2 : remove blank line #

Patch Set 3 : remove mojo file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/common/importer/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/utility/importer/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-14 21:15:43 UTC) #3
gab
importer/ lgtm
3 years, 10 months ago (2017-02-14 22:08:23 UTC) #4
meacer
chrome/browser/media/router/mojo/OWNERS lgtm
3 years, 10 months ago (2017-02-15 00:59:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696013003/40001
3 years, 10 months ago (2017-02-16 00:11:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/212803)
3 years, 10 months ago (2017-02-16 01:06:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696013003/60001
3 years, 10 months ago (2017-02-16 23:31:21 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 01:16:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3a6c5f97a4013fa27b9e5a47d71c...

Powered by Google App Engine
This is Rietveld 408576698