|
|
Descriptionoka@ and yhanada@ watch virtual keyboard CLs.
BUG=None
Review-Url: https://codereview.chromium.org/2695983002
Cr-Commit-Position: refs/heads/master@{#451227}
Committed: https://chromium.googlesource.com/chromium/src/+/bf9f6f02278622a710524fdd36226c77c4f5cab8
Patch Set 1 #
Messages
Total messages: 22 (9 generated)
oka@chromium.org changed reviewers: + yhanada@chromium.org
PTAL. This is the same as https://codereview.chromium.org/2692613002, but created as @chromium.org, not @google.com so that I can commit it.
Friendly ping?
The CQ bit was checked by oka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
lgtm
lgtm
The CQ bit was checked by oka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
oka@chromium.org changed reviewers: + fukino@chromium.org
Fukino-san, could you grant committer approval? I got L-GTM from Hanada-san, but he seems not a committer yet.
lgtm
The CQ bit was checked by oka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1487304064634110, "parent_rev": "aac85d78a79fe653d913ad9278c18da28900a25b", "commit_rev": "bf9f6f02278622a710524fdd36226c77c4f5cab8"}
Message was sent while issue was closed.
Description was changed from ========== oka@ and yhanada@ watch virtual keyboard CLs. BUG=None ========== to ========== oka@ and yhanada@ watch virtual keyboard CLs. BUG=None Review-Url: https://codereview.chromium.org/2695983002 Cr-Commit-Position: refs/heads/master@{#451227} Committed: https://chromium.googlesource.com/chromium/src/+/bf9f6f02278622a710524fdd3622... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bf9f6f02278622a710524fdd3622... |