Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2695933003: Remove V8IsolateInterruptor (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove V8IsolateInterruptor Now that Oilpan doesn't have a shared heap, we don't need to have a mechanism to interrupt V8 script execution. BUG=671856 Review-Url: https://codereview.chromium.org/2695933003 Cr-Commit-Position: refs/heads/master@{#450673} Committed: https://chromium.googlesource.com/chromium/src/+/e1557e4bdddb3eb9f30a2d95b6e094d15b93ded5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
haraken
PTAL
3 years, 10 months ago (2017-02-15 09:13:36 UTC) #2
sof
lgtm
3 years, 10 months ago (2017-02-15 09:20:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695933003/1
3 years, 10 months ago (2017-02-15 09:24:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/232872)
3 years, 10 months ago (2017-02-15 11:08:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695933003/1
3 years, 10 months ago (2017-02-15 11:10:43 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 12:06:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e1557e4bdddb3eb9f30a2d95b6e0...

Powered by Google App Engine
This is Rietveld 408576698