Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 269593009: Encoding API: Update tests and simplify constructors (Closed)

Created:
6 years, 7 months ago by jsbell
Modified:
6 years, 7 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Encoding API: Update tests and simplify constructors Add a snapshot of the WHATWG Encoding spec's encodings.js and document the deltas from it in shared.js. Skip testing "replacement" encodings. Also, Simplify the constructors by just passing through a TextEncoding object rather than digging out a string then recreating it. No functional changes. BUG=277037 R=jshin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -38 lines) Patch
M LayoutTests/fast/encoding/api/ascii-supersets.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/encoding/api/ascii-supersets-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/encoding/api/encoding-labels.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/fast/encoding/api/encoding-labels-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/fast/encoding/api/legacy-encode-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A LayoutTests/fast/encoding/api/resources/encodings.json View 1 chunk +453 lines, -0 lines 0 comments Download
M LayoutTests/fast/encoding/api/resources/shared.js View 5 chunks +23 lines, -18 lines 0 comments Download
M Source/modules/encoding/TextDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextDecoder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/encoding/TextEncoder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextEncoder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jsbell
jshin@ - part 1 of the "replacement" encoding landing. This is just trivial API test/impl ...
6 years, 7 months ago (2014-05-02 00:16:02 UTC) #1
jsbell
This is part 1 of 3. The full sequence is: 1. API/test cleanup - https://codereview.chromium.org/269593009 ...
6 years, 7 months ago (2014-05-02 18:39:25 UTC) #2
eseidel
lgtm
6 years, 7 months ago (2014-05-09 06:38:04 UTC) #3
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 7 months ago (2014-05-09 15:20:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/269593009/1
6 years, 7 months ago (2014-05-09 15:20:45 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 15:31:26 UTC) #6
Message was sent while issue was closed.
Change committed as 173754

Powered by Google App Engine
This is Rietveld 408576698