Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2695923006: Headless: Add a test for Network.AddBlockedURL (Closed)

Created:
3 years, 10 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 10 months ago
Reviewers:
Sami
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Headless: Add a test for Network.AddBlockedURL There doesn't appear to be any test coverage for this, and I wanted to make sure it's working in headless. BUG=546953 Review-Url: https://codereview.chromium.org/2695923006 Cr-Commit-Position: refs/heads/master@{#450661} Committed: https://chromium.googlesource.com/chromium/src/+/e28992d90ab8894f66fa7bb8a12c09f9d9ec2843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M headless/lib/headless_devtools_client_browsertest.cc View 3 chunks +62 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
alex clarke (OOO till 29th)
3 years, 10 months ago (2017-02-15 10:49:18 UTC) #3
Sami
lgtm.
3 years, 10 months ago (2017-02-15 11:07:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695923006/1
3 years, 10 months ago (2017-02-15 11:07:59 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 11:13:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e28992d90ab8894f66fa7bb8a12c...

Powered by Google App Engine
This is Rietveld 408576698