Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2695883005: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
Reviewers:
Guido Urdaneta
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, abarth-chromium, blink-reviews, tommyw+watchlist_chromium.org, darin-cc_chromium.org, haraken, mcasas+watch+mediastream_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=guidou Review-Url: https://codereview.chromium.org/2695883005 Cr-Commit-Position: refs/heads/master@{#450835} Committed: https://chromium.googlesource.com/chromium/src/+/4121a7c0e54516b0971ed617978e0bcd7d6b79f9

Patch Set 1 : ADD TEAM/COMPONENT #

Total comments: 2

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/audio_output_devices/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/srcobject/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. I have split the previous cl ...
3 years, 10 months ago (2017-02-14 21:45:10 UTC) #2
ymzhang1
Resend to add reviewer email.
3 years, 10 months ago (2017-02-14 21:47:15 UTC) #5
Guido Urdaneta
lgtm, provided you make the change to modules/audio_output_devices https://codereview.chromium.org/2695883005/diff/20001/third_party/WebKit/Source/modules/audio_output_devices/OWNERS File third_party/WebKit/Source/modules/audio_output_devices/OWNERS (right): https://codereview.chromium.org/2695883005/diff/20001/third_party/WebKit/Source/modules/audio_output_devices/OWNERS#newcode4 third_party/WebKit/Source/modules/audio_output_devices/OWNERS:4: # ...
3 years, 10 months ago (2017-02-15 11:19:40 UTC) #6
ymzhang1
https://codereview.chromium.org/2695883005/diff/20001/third_party/WebKit/Source/modules/audio_output_devices/OWNERS File third_party/WebKit/Source/modules/audio_output_devices/OWNERS (right): https://codereview.chromium.org/2695883005/diff/20001/third_party/WebKit/Source/modules/audio_output_devices/OWNERS#newcode4 third_party/WebKit/Source/modules/audio_output_devices/OWNERS:4: # COMPONENT: Blink>Media>Audio On 2017/02/15 11:19:40, Guido Urdaneta wrote: ...
3 years, 10 months ago (2017-02-15 17:48:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695883005/60001
3 years, 10 months ago (2017-02-15 21:45:50 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 23:39:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4121a7c0e54516b0971ed617978e...

Powered by Google App Engine
This is Rietveld 408576698