Prevent some string copies when sending Values to WebUI.

Prevent some string copies when sending Values to WebUI.

WebUI::GetJavascriptCall is called with large data structures sometimes, which
serialize to large JSON strings. The previous "operator +" style code generated
large intermediate temporaries which can be easily avoided.

Added a clarifying comment to the JSON writer.

Review-Url: https://codereview.chromium.org/2695873002
Cr-Commit-Position: refs/heads/master@{#450516}
Committed: https://chromium.googlesource.com/chromium/src/+/ee699e9ecfbaf7441d5ad5d71d2e7f5db15afde7

[brettw, 2017-02-13 22:47:32]

Description was changed from

==========
Prevent some string copies when sending Values to WebUI.

WebUI::GetJavascriptCall is called with large data structures sometimes, which
serialize to large JSON strings. The previous "operator +" style code generated
large intermediate temporaries which can be easily avoided.
==========

to

==========
Prevent some string copies when sending Values to WebUI.

WebUI::GetJavascriptCall is called with large data structures sometimes, which
serialize to large JSON strings. The previous "operator +" style code generated
large intermediate temporaries which can be easily avoided.

Added a clarifying comment to the JSON writer.
==========

[brettw, 2017-02-13 22:47:32]

brettw@chromium.org changed reviewers:
+ jam@chromium.org

[brettw, 2017-02-13 22:47:42]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 22:48:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-02-13 23:15:39]

lgtm

[commit-bot: I haz the power, 2017-02-14 00:43:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 00:43:41]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-02-14 22:10:01]

Patchset #2 (id:20001) has been deleted

[brettw, 2017-02-14 22:10:41]

Removed another copy

[brettw, 2017-02-14 22:10:41]

The CQ bit was checked by brettw@chromium.org

[brettw, 2017-02-14 22:10:42]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2695873002/#ps40001
(title: "Removed another copy")

[commit-bot: I haz the power, 2017-02-14 22:11:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 23:53:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487110241670260,
"parent_rev": "0395dba8e185b1a04a81f53bec3767fb4cea2f3f", "commit_rev":
"ee699e9ecfbaf7441d5ad5d71d2e7f5db15afde7"}

[commit-bot: I haz the power, 2017-02-14 23:54:05]

Description was changed from

==========
Prevent some string copies when sending Values to WebUI.

WebUI::GetJavascriptCall is called with large data structures sometimes, which
serialize to large JSON strings. The previous "operator +" style code generated
large intermediate temporaries which can be easily avoided.

Added a clarifying comment to the JSON writer.
==========

to

==========
Prevent some string copies when sending Values to WebUI.

WebUI::GetJavascriptCall is called with large data structures sometimes, which
serialize to large JSON strings. The previous "operator +" style code generated
large intermediate temporaries which can be easily avoided.

Added a clarifying comment to the JSON writer.

Review-Url: https://codereview.chromium.org/2695873002
Cr-Commit-Position: refs/heads/master@{#450516}
Committed:
https://chromium.googlesource.com/chromium/src/+/ee699e9ecfbaf7441d5ad5d71d2e...
==========

[commit-bot: I haz the power, 2017-02-14 23:54:12]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ee699e9ecfbaf7441d5ad5d71d2e...