Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2695833008: Make CHECK int 3 on Windows, rather than crash (Closed)

Created:
3 years, 10 months ago by scottmg
Modified:
3 years, 10 months ago
Reviewers:
Will Harris
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Make CHECK int 3 on Windows, rather than crash Not being able to distinguish intentional crashes (CHECK) from unintentional ones (other access violations) in terms of exit codes reduces the amount of signal we have in stability metrics. R=wfh@chromium.org BUG=664209, 687326 Review-Url: https://codereview.chromium.org/2676483002 Cr-Commit-Position: refs/heads/master@{#450809} (cherry picked from commit a17c8db528cadca9eef98ce03b0910700735722e) Review-Url: https://codereview.chromium.org/2695833008 . Cr-Commit-Position: refs/branch-heads/2987@{#564} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/225319af95b483fc525e08149b4d1d64524dd9c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -2 lines) Patch
M base/logging.h View 1 chunk +4 lines, -2 lines 0 comments Download
M base/logging_unittest.cc View 2 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
scottmg
3 years, 10 months ago (2017-02-16 22:16:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
225319af95b483fc525e08149b4d1d64524dd9c4.

Powered by Google App Engine
This is Rietveld 408576698