Remove libgtk3ui from gn_all

Remove libgtk3ui from gn_all

Now that Chromium is switching to use_gtk3=true by default, it is
unnecessary to build libgtk3ui from gn_all.

In addition, this CL also guards libgtk2ui with !use_gtk3 so that
gtk+-2.0.pc is not required during gn gen (and so gtk+-3.0.pc is not
required for a gtk2 build).

BUG=668446
R=dpranke@chromium.org,erg@chromium.org

Review-Url: https://codereview.chromium.org/2695823006
Cr-Commit-Position: refs/heads/master@{#450611}
Committed: https://chromium.googlesource.com/chromium/src/+/108710bef84807a01bb0776e5011d1ce0709fca0

[Tom (Use chromium acct), 2017-02-14 23:22:00]

Description was changed from

==========
Remove Gtk3 from gn_all

Now that Chromium is switching to use_gtk3=true by default, it is
unnecessary to build libgtk3ui from gn_all.

In addition, this CL also guards libgtk2ui with !use_gtk3 so that
gtk+-2.0.pc is not required during gn gen (and so gtk+-3.0.pc is not
required for a gtk2 build).

BUG=668446
R=dpranke@chromium.org
==========

to

==========
Remove Gtk3 from gn_all

Now that Chromium is switching to use_gtk3=true by default, it is
unnecessary to build libgtk3ui from gn_all.

In addition, this CL also guards libgtk2ui with !use_gtk3 so that
gtk+-2.0.pc is not required during gn gen (and so gtk+-3.0.pc is not
required for a gtk2 build).

BUG=668446
R=dpranke@chromium.org,erg@chromium.org
==========

[Tom (Use chromium acct), 2017-02-14 23:22:00]

thomasanderson@google.com changed reviewers:
+ erg@chromium.org

[Tom (Use chromium acct), 2017-02-14 23:22:12]

erg and dpranke ptal

[Tom (Use chromium acct), 2017-02-14 23:22:34]

On 2017/02/14 23:22:12, Tom Anderson wrote:
> erg and dpranke ptal

dpranke: BUILD.gn
erg: chrome/browser/ui/libgtkui/BUILD.gn

[Elliot Glaysher, 2017-02-14 23:24:41]

exciting!

lgtm

[Tom (Use chromium acct), 2017-02-14 23:34:23]

Description was changed from

==========
Remove Gtk3 from gn_all

Now that Chromium is switching to use_gtk3=true by default, it is
unnecessary to build libgtk3ui from gn_all.

In addition, this CL also guards libgtk2ui with !use_gtk3 so that
gtk+-2.0.pc is not required during gn gen (and so gtk+-3.0.pc is not
required for a gtk2 build).

BUG=668446
R=dpranke@chromium.org,erg@chromium.org
==========

to

==========
Remove libgtk3ui from gn_all

Now that Chromium is switching to use_gtk3=true by default, it is
unnecessary to build libgtk3ui from gn_all.

In addition, this CL also guards libgtk2ui with !use_gtk3 so that
gtk+-2.0.pc is not required during gn gen (and so gtk+-3.0.pc is not
required for a gtk2 build).

BUG=668446
R=dpranke@chromium.org,erg@chromium.org
==========

[Dirk Pranke, 2017-02-14 23:37:14]

lgtm

[Tom (Use chromium acct), 2017-02-14 23:37:46]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-02-14 23:38:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 06:54:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487115466467190, "parent_rev":
"ef61042c2a397f29abf745448a492617cb81a4c2", "commit_rev":
"108710bef84807a01bb0776e5011d1ce0709fca0"}

[commit-bot: I haz the power, 2017-02-15 06:54:48]

Description was changed from

==========
Remove libgtk3ui from gn_all

Now that Chromium is switching to use_gtk3=true by default, it is
unnecessary to build libgtk3ui from gn_all.

In addition, this CL also guards libgtk2ui with !use_gtk3 so that
gtk+-2.0.pc is not required during gn gen (and so gtk+-3.0.pc is not
required for a gtk2 build).

BUG=668446
R=dpranke@chromium.org,erg@chromium.org
==========

to

==========
Remove libgtk3ui from gn_all

Now that Chromium is switching to use_gtk3=true by default, it is
unnecessary to build libgtk3ui from gn_all.

In addition, this CL also guards libgtk2ui with !use_gtk3 so that
gtk+-2.0.pc is not required during gn gen (and so gtk+-3.0.pc is not
required for a gtk2 build).

BUG=668446
R=dpranke@chromium.org,erg@chromium.org

Review-Url: https://codereview.chromium.org/2695823006
Cr-Commit-Position: refs/heads/master@{#450611}
Committed:
https://chromium.googlesource.com/chromium/src/+/108710bef84807a01bb0776e5011...
==========

[commit-bot: I haz the power, 2017-02-15 06:54:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/108710bef84807a01bb0776e5011...