Issue 2695823005: Revert "Switch to the new analysis driver in analyzer_cli."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2695823005: Revert "Switch to the new analysis driver in analyzer_cli." (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Switch to the new analysis driver in analyzer_cli." This reverts commit cda7520e5c19425637351be5eae04af7e3136111. There is a couple of integration tests for embedder analyzer_cli which are failing, and I cannot find the solution quickly. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e97042bec363b66ea4b6247a158e17ddc9137ca3

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -44 lines)			Patch
M	pkg/analyzer_cli/lib/src/analyzer_impl.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	pkg/analyzer_cli/lib/src/driver.dart	View	5 chunks	+16 lines, -26 lines	0 comments	Download
M	pkg/analyzer_cli/lib/src/options.dart	View	4 chunks	+2 lines, -12 lines	0 comments	Download
M	sdk/bin/dartanalyzer	View	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as e97042bec363b66ea4b6247a158e17ddc9137ca3 (presubmit successful).

3 years, 10 months ago (2017-02-14 20:35:53 UTC) #3

Message was sent while issue was closed.

Sad, but probably best. lgtm.