Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: pkg/analyzer_cli/lib/src/options.dart

Issue 2695823005: Revert "Switch to the new analysis driver in analyzer_cli." (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer_cli/lib/src/driver.dart ('k') | sdk/bin/dartanalyzer » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/lib/src/options.dart
diff --git a/pkg/analyzer_cli/lib/src/options.dart b/pkg/analyzer_cli/lib/src/options.dart
index 915d04366022d868d89ff059501a0b2f844ffb0a..7dd9de9317afa75fedd7b6b9f8c0ef61166ea032 100644
--- a/pkg/analyzer_cli/lib/src/options.dart
+++ b/pkg/analyzer_cli/lib/src/options.dart
@@ -33,7 +33,7 @@ typedef void ExitHandler(int code);
/// Analyzer commandline configuration options.
class CommandLineOptions {
- final bool enableNewAnalysisDriver = true;
+ final bool enableNewAnalysisDriver = false;
/// The path to output analysis results when in build mode.
final String buildAnalysisOutput;
@@ -143,9 +143,6 @@ class CommandLineOptions {
/// Whether to treat lints as fatal
final bool lintsAreFatal;
- /// Whether to use memory byte store for analysis driver.
- final bool useAnalysisDriverMemoryByteStore;
-
/// Initialize options from the given parsed [args].
CommandLineOptions._fromArgs(ArgResults args)
: buildAnalysisOutput = args['build-analysis-output'],
@@ -184,9 +181,7 @@ class CommandLineOptions {
strongMode = args['strong'],
implicitCasts = !args['no-implicit-casts'],
implicitDynamic = !args['no-implicit-dynamic'],
- lintsAreFatal = args['fatal-lints'],
- useAnalysisDriverMemoryByteStore =
- args['use-analysis-driver-memory-byte-store'];
+ lintsAreFatal = args['fatal-lints'];
/// The path to an analysis options file
String get analysisOptionsFile =>
@@ -458,11 +453,6 @@ class CommandLineOptions {
help: 'Check types in constant evaluation.',
defaultsTo: false,
negatable: false,
- hide: hide)
- ..addFlag('use-analysis-driver-memory-byte-store',
- help: 'Use memory byte store, not the file system cache.',
- defaultsTo: false,
- negatable: false,
hide: hide);
try {
« no previous file with comments | « pkg/analyzer_cli/lib/src/driver.dart ('k') | sdk/bin/dartanalyzer » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698