[debugger] add lcov support to d8.

[debugger] add lcov support to d8.

Use d8 with --lcov=<file> to append coverage info to a file.
The result can be fed into genhtml(1).

R=jgruber@chromium.org
BUG=v8:5808
Review-Url: https://codereview.chromium.org/2695823003
Cr-Commit-Position: refs/heads/master@{#43207}
Committed: https://chromium.googlesource.com/v8/v8/+/20c7d5431ac93054574d5ac06eed9549dbe39a96

[Yang, 2017-02-14 08:59:11]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 08:59:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 09:05:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 09:05:38]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)

[jgruber, 2017-02-15 08:20:23]

lgtm

https://codereview.chromium.org/2695823003/diff/20001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2695823003/diff/20001/src/d8.cc#newcode2470
src/d8.cc:2470: } else if (strncmp(argv[i], "--lcov=", 6) == 0) {
Shouldn't this be 7 (to include the '=') here and below?

[Yang, 2017-02-15 09:31:02]

On 2017/02/15 08:20:23, jgruber wrote:
> lgtm
> 
> https://codereview.chromium.org/2695823003/diff/20001/src/d8.cc
> File src/d8.cc (right):
> 
> https://codereview.chromium.org/2695823003/diff/20001/src/d8.cc#newcode2470
> src/d8.cc:2470: } else if (strncmp(argv[i], "--lcov=", 6) == 0) {
> Shouldn't this be 7 (to include the '=') here and below?

thanks for the catch! Also implemented for non-linux builds.

[Yang, 2017-02-15 09:31:41]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-02-15 09:31:41]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2695823003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-15 09:31:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 09:39:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 09:39:42]

Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Yang, 2017-02-15 09:41:40]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-02-15 09:41:41]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2695823003/#ps80001
(title: "fix compile")

[commit-bot: I haz the power, 2017-02-15 09:41:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 09:44:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 09:44:42]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/21023)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/21054)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[Yang, 2017-02-15 09:46:21]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-02-15 09:46:21]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2695823003/#ps100001
(title: "actual fix")

[commit-bot: I haz the power, 2017-02-15 09:46:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-02-15 09:56:32]

Description was changed from

==========
[debugger] add lcov support to d8.

Use d8 with --lcov=<file> to write a coverage info file.

R=jgruber@chromium.org
BUG=v8:5808
==========

to

==========
[debugger] add lcov support to d8.

Use d8 with --lcov=<file> to write a coverage info file.
The resulting coverage info can be used with genhtml(1).

R=jgruber@chromium.org
BUG=v8:5808
==========

[Yang, 2017-02-15 09:57:16]

Description was changed from

==========
[debugger] add lcov support to d8.

Use d8 with --lcov=<file> to write a coverage info file.
The resulting coverage info can be used with genhtml(1).

R=jgruber@chromium.org
BUG=v8:5808
==========

to

==========
[debugger] add lcov support to d8.

Use d8 with --lcov=<file> to append coverage info to a file.
The result can be fed into genhtml(1).

R=jgruber@chromium.org
BUG=v8:5808
==========

[commit-bot: I haz the power, 2017-02-15 10:16:45]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487151981036490,
"parent_rev": "65f0e958f6d5ac0e7d8bc2fc392909da7e81a909", "commit_rev":
"20c7d5431ac93054574d5ac06eed9549dbe39a96"}

[commit-bot: I haz the power, 2017-02-15 10:16:49]

Description was changed from

==========
[debugger] add lcov support to d8.

Use d8 with --lcov=<file> to append coverage info to a file.
The result can be fed into genhtml(1).

R=jgruber@chromium.org
BUG=v8:5808
==========

to

==========
[debugger] add lcov support to d8.

Use d8 with --lcov=<file> to append coverage info to a file.
The result can be fed into genhtml(1).

R=jgruber@chromium.org
BUG=v8:5808

Review-Url: https://codereview.chromium.org/2695823003
Cr-Commit-Position: refs/heads/master@{#43207}
Committed:
https://chromium.googlesource.com/v8/v8/+/20c7d5431ac93054574d5ac06eed9549dbe...
==========

[commit-bot: I haz the power, 2017-02-15 10:16:50]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/20c7d5431ac93054574d5ac06eed9549dbe...