Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 2695813011: Updates for improved PMA 'object' interface. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by bcwhite
Modified:
1 week, 1 day ago
Reviewers:
manzagop
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates for improved PMA 'object' interface. BUG=620813 Review-Url: https://codereview.chromium.org/2695813011 Cr-Commit-Position: refs/heads/master@{#451342} Committed: https://chromium.googlesource.com/chromium/src/+/a2191ee363dcb554d237ee14faf21db825f146a5

Patch Set 1 #

Total comments: 2

Patch Set 2 : no statics for unions #

Total comments: 1

Patch Set 3 : fixed Activity size #

Messages

Total messages: 20 (14 generated)
bcwhite
1 week, 1 day ago (2017-02-17 15:11:21 UTC) #4
manzagop
lgtm https://codereview.chromium.org/2695813011/diff/1/base/debug/activity_tracker.h File base/debug/activity_tracker.h (right): https://codereview.chromium.org/2695813011/diff/1/base/debug/activity_tracker.h#newcode67 base/debug/activity_tracker.h:67: static constexpr size_t kExpectedInstanceSize = 8; static_assert for ...
1 week, 1 day ago (2017-02-17 15:50:55 UTC) #9
manzagop
Oops ignore the comment duplication, I got confused by the second patch .
1 week, 1 day ago (2017-02-17 15:52:02 UTC) #10
bcwhite
https://codereview.chromium.org/2695813011/diff/1/base/debug/activity_tracker.h File base/debug/activity_tracker.h (right): https://codereview.chromium.org/2695813011/diff/1/base/debug/activity_tracker.h#newcode67 base/debug/activity_tracker.h:67: static constexpr size_t kExpectedInstanceSize = 8; On 2017/02/17 15:50:55, ...
1 week, 1 day ago (2017-02-17 15:52:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695813011/40001
1 week, 1 day ago (2017-02-17 18:02:18 UTC) #17
commit-bot: I haz the power
1 week, 1 day ago (2017-02-17 18:31:05 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a2191ee363dcb554d237ee14faf2...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd