Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2695813011:
Updates for improved PMA 'object' interface. (Closed)
|
Created:
3 years, 10 months ago by bcwhite Modified:
3 years, 10 months ago Reviewers:
manzagop (departed) CC:
chromium-reviews, vmpstr+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdates for improved PMA 'object' interface.
BUG=620813
Review-Url: https://codereview.chromium.org/2695813011
Cr-Commit-Position: refs/heads/master@{#451342}
Committed: https://chromium.googlesource.com/chromium/src/+/a2191ee363dcb554d237ee14faf21db825f146a5
Patch Set 1 #
Total comments: 2
Patch Set 2 : no statics for unions #
Total comments: 1
Patch Set 3 : fixed Activity size #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bcwhite@chromium.org changed reviewers: + manzagop@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2695813011/diff/1/base/debug/activity_tracker.h File base/debug/activity_tracker.h (right): https://codereview.chromium.org/2695813011/diff/1/base/debug/activity_tracker... base/debug/activity_tracker.h:67: static constexpr size_t kExpectedInstanceSize = 8; static_assert for this? Same below. https://codereview.chromium.org/2695813011/diff/20001/base/debug/activity_tra... File base/debug/activity_tracker.h (right): https://codereview.chromium.org/2695813011/diff/20001/base/debug/activity_tra... base/debug/activity_tracker.h:204: static constexpr size_t kExpectedInstanceSize = 56; static assert the size?
Oops ignore the comment duplication, I got confused by the second patch .
https://codereview.chromium.org/2695813011/diff/1/base/debug/activity_tracker.h File base/debug/activity_tracker.h (right): https://codereview.chromium.org/2695813011/diff/1/base/debug/activity_tracker... base/debug/activity_tracker.h:67: static constexpr size_t kExpectedInstanceSize = 8; On 2017/02/17 15:50:55, manzagop wrote: > static_assert for this? Same below. These sizes are asserted by the PMA when using the object interface.
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bcwhite@chromium.org
The CQ bit was checked by bcwhite@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from manzagop@chromium.org Link to the patchset: https://codereview.chromium.org/2695813011/#ps40001 (title: "fixed Activity size")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487354483832110,
"parent_rev": "6cb36ccfdb9a811a5839677d894595d79ed5b8af", "commit_rev":
"a2191ee363dcb554d237ee14faf21db825f146a5"}
Message was sent while issue was closed.
Description was changed from ========== Updates for improved PMA 'object' interface. BUG=620813 ========== to ========== Updates for improved PMA 'object' interface. BUG=620813 Review-Url: https://codereview.chromium.org/2695813011 Cr-Commit-Position: refs/heads/master@{#451342} Committed: https://chromium.googlesource.com/chromium/src/+/a2191ee363dcb554d237ee14faf2... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a2191ee363dcb554d237ee14faf2... |
