Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2695813003:
Document how to write configs for iOS bots (Closed)
DescriptionDocument how to write configs for iOS bots
BUG=686969
R=justincohen@chromium.org, sdefresne@chromium.org
Review-Url: https://codereview.chromium.org/2695813003 .
Cr-Commit-Position: refs/heads/master@{#452274}
Committed: https://chromium.googlesource.com/chromium/src/+/14e3f8a1335feea42ee529a1381619d579f3c442
Patch Set 1 #
Total comments: 2
Patch Set 2 : Lowercase #Messages
Total messages: 20 (9 generated)
smut@google.com changed reviewers: + baxley@chromium.org, sdefresne@chromium.org
+justincohen CL explains how to modify gn_args and pass command line flags to a test. Let me know if it's clear or not.
Description was changed from ========== Document how to write configs for iOS bots BUG=686969 ========== to ========== Document how to write configs for iOS bots BUG=686969 ==========
smut@google.com changed reviewers: + justincohen@chromium.org
On 2017/02/15 21:11:57, smut wrote: > +justincohen > > CL explains how to modify gn_args and pass command line flags to a test. Let me > know if it's clear or not. +justincohen for real.
lgtm
lgtm https://codereview.chromium.org/2695813003/diff/1/docs/ios_infra.md File docs/ios_infra.md (right): https://codereview.chromium.org/2695813003/diff/1/docs/ios_infra.md#newcode212 docs/ios_infra.md:212: and it may define a Boolean value `xctest` to indicate whether the test is an nit: I would use "boolean" here
https://codereview.chromium.org/2695813003/diff/1/docs/ios_infra.md File docs/ios_infra.md (right): https://codereview.chromium.org/2695813003/diff/1/docs/ios_infra.md#newcode212 docs/ios_infra.md:212: and it may define a Boolean value `xctest` to indicate whether the test is an On 2017/02/17 10:02:45, sdefresne wrote: > nit: I would use "boolean" here Done.
The CQ bit was checked by smut@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org, justincohen@chromium.org Link to the patchset: https://codereview.chromium.org/2695813003/#ps20001 (title: "Lowercase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by smut@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
Description was changed from ========== Document how to write configs for iOS bots BUG=686969 ========== to ========== Document how to write configs for iOS bots BUG=686969 R=justincohen@chromium.org, sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2695813003 . Cr-Commit-Position: refs/heads/master@{#452274} Committed: https://chromium.googlesource.com/chromium/src/+/14e3f8a1335feea42ee529a13816... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 14e3f8a1335feea42ee529a1381619d579f3c442. |
