Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2695813002: Add Subzero as a third_party dependency (Closed)

Created:
3 years, 10 months ago by sugoi1
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Subzero as a third_party dependency As discussed, Subzero is added as a third_party dependency in Chromium. Subzero's revision is defined in SwiftShader's DEPS file and it will be pulled in 'third_party/swiftshader/third_party/pnacl-subzero'. BUG=630728 Review-Url: https://codereview.chromium.org/2695813002 Cr-Commit-Position: refs/heads/master@{#450353} Committed: https://chromium.googlesource.com/chromium/src/+/a231f957275b8be1a1bf97b25acbae7e49328a36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M DEPS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sugoi1
This cl implements what was discussed on the thread entitled "Adding Subzero to Third_party" on ...
3 years, 10 months ago (2017-02-13 19:42:33 UTC) #5
Dirk Pranke
lgtm
3 years, 10 months ago (2017-02-13 23:53:54 UTC) #8
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-14 12:19:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695813002/1
3 years, 10 months ago (2017-02-14 14:57:33 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 15:07:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a231f957275b8be1a1bf97b25acb...

Powered by Google App Engine
This is Rietveld 408576698