Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2695803003: [DevTools] Fix GlassPane choosing anchor side. (Closed)

Created:
3 years, 10 months ago by dgozman
Modified:
3 years, 10 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix GlassPane choosing anchor side. When there is not enough space, we should choose the side with more available space. BUG=691446 Review-Url: https://codereview.chromium.org/2695803003 Cr-Commit-Position: refs/heads/master@{#450475} Committed: https://chromium.googlesource.com/chromium/src/+/387634186f3ce6ff5ed312e8012c63545e3c9f09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dgozman
Could you please take a look? Regressed in https://chromium.googlesource.com/chromium/src/+/ed1f2fac6209f8d2e0db3f7dcff38d1e69f5db26
3 years, 10 months ago (2017-02-13 23:47:35 UTC) #2
lushnikov
lgtm
3 years, 10 months ago (2017-02-14 00:41:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695803003/1
3 years, 10 months ago (2017-02-14 00:42:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/381872)
3 years, 10 months ago (2017-02-14 01:23:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695803003/1
3 years, 10 months ago (2017-02-14 18:46:49 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 21:14:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/387634186f3ce6ff5ed312e8012c...

Powered by Google App Engine
This is Rietveld 408576698