Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2695713011: PlzNavigate: set the right cache policy on back POST navigations (Closed)

Created:
3 years, 10 months ago by clamy
Modified:
3 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, blink-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: set the right cache policy on back POST navigations We would repviously set the cache policy to net::LOAD_VALIDATE_CACHE in that case. It should be net::LOAD_ONLY_FROM_CACHE | net::LOAD_SKIP_CACHE_VALIDATION. BUG=608372 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2695713011 Cr-Commit-Position: refs/heads/master@{#451010} Committed: https://chromium.googlesource.com/chromium/src/+/74feab800a38e1cc133c3406d19f966844881e42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M content/browser/frame_host/navigation_request.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
clamy
@nasko: PTAL
3 years, 10 months ago (2017-02-16 14:15:29 UTC) #6
nasko
LGTM
3 years, 10 months ago (2017-02-16 15:01:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695713011/1
3 years, 10 months ago (2017-02-16 17:36:22 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 17:48:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/74feab800a38e1cc133c3406d19f...

Powered by Google App Engine
This is Rietveld 408576698