components/ntp_tiles/most_visited_sites.h - Issue 2695713004: Add baked-in favicons for default popular sites on NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/most_visited_sites.h

Issue 2695713004: Add baked-in favicons for default popular sites on NTP (Closed)

Patch Set: Drop bool from callback Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_tiles/most_visited_sites.h

diff --git a/components/ntp_tiles/most_visited_sites.h b/components/ntp_tiles/most_visited_sites.h

index 5df1fc6687454a691f42a627c2bc5ea2efa3d0ef..12cf44e6eb2c05dc6188270b3a80bbc1f8fcb320 100644

--- a/components/ntp_tiles/most_visited_sites.h

+++ b/components/ntp_tiles/most_visited_sites.h

@@ -181,7 +181,7 @@ class MostVisitedSites : public history::TopSitesObserver,

void OnPopularSitesDownloaded(bool success);

- void OnIconMadeAvailable(const GURL& site_url, bool newly_available);

+ void OnIconMadeAvailable(const GURL& site_url);

// history::TopSitesObserver implementation.

void TopSitesLoaded(history::TopSites* top_sites) override;