components/ntp_tiles/most_visited_sites.cc - Issue 2695713004: Add baked-in favicons for default popular sites on NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/most_visited_sites.cc

Issue 2695713004: Add baked-in favicons for default popular sites on NTP (Closed)

Patch Set: Drop bool from callback Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_tiles/most_visited_sites.cc

diff --git a/components/ntp_tiles/most_visited_sites.cc b/components/ntp_tiles/most_visited_sites.cc

index f3695c9946ec90bfe44a7e89456e6e539e820fd9..45a6717f693ed5db1abf14ecd771ffa30d2604b2 100644

--- a/components/ntp_tiles/most_visited_sites.cc

+++ b/components/ntp_tiles/most_visited_sites.cc

@@ -420,10 +420,8 @@ void MostVisitedSites::OnPopularSitesDownloaded(bool success) {

}

-void MostVisitedSites::OnIconMadeAvailable(const GURL& site_url,

- bool newly_available) {

- if (newly_available)

- observer_->OnIconMadeAvailable(site_url);

+void MostVisitedSites::OnIconMadeAvailable(const GURL& site_url) {

+ observer_->OnIconMadeAvailable(site_url);

}

void MostVisitedSites::TopSitesLoaded(TopSites* top_sites) {}