Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2695693002: Shrink to fit the label on ReadingListToolbar (Closed)

Created:
3 years, 10 months ago by gambard
Modified:
3 years, 10 months ago
Reviewers:
Olivier
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shrink to fit the label on ReadingListToolbar Shrink the font of the labels in ReadingListToolbar if the label span on more than 3 lines. BUG=688513 Review-Url: https://codereview.chromium.org/2695693002 Cr-Commit-Position: refs/heads/master@{#449940} Committed: https://chromium.googlesource.com/chromium/src/+/7a8b621535abb3aa5d9c0ff2196299f1d90449a5

Patch Set 1 #

Patch Set 2 : Set it to 3 lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ios/chrome/browser/ui/reading_list/reading_list_toolbar.mm View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
gambard
PTAL.
3 years, 10 months ago (2017-02-13 13:10:45 UTC) #2
Olivier
lgtm
3 years, 10 months ago (2017-02-13 13:22:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695693002/20001
3 years, 10 months ago (2017-02-13 13:23:00 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 13:33:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7a8b621535abb3aa5d9c0ff21962...

Powered by Google App Engine
This is Rietveld 408576698