Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2695663002: headless: Add generated version header (Closed)

Created:
3 years, 10 months ago by Sami
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Add generated version header This header can be used to determine which Chromium revision was used to build headless. BUG=691507 Review-Url: https://codereview.chromium.org/2695663002 Cr-Commit-Position: refs/heads/master@{#449935} Committed: https://chromium.googlesource.com/chromium/src/+/da9d63951e492f669ea947d700d3bafc5bfdd0e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M headless/BUILD.gn View 3 chunks +11 lines, -0 lines 0 comments Download
A headless/public/version.h.in View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Sami
3 years, 10 months ago (2017-02-13 11:14:46 UTC) #5
alex clarke (OOO till 29th)
lgtm
3 years, 10 months ago (2017-02-13 11:15:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695663002/1
3 years, 10 months ago (2017-02-13 11:39:09 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 12:25:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da9d63951e492f669ea947d700d3...

Powered by Google App Engine
This is Rietveld 408576698