Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1664)

Issue 2695633007: Revert of Put the BackgroundHTMLParser on oilpan heap (Closed)

Created:
3 years, 10 months ago by Charlie Harrison
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Put the BackgroundHTMLParser on oilpan heap (patchset #6 id:100001 of https://codereview.chromium.org/2683653004/ ) Reason for revert: Causing frequent crashes: crbug.com/692999 Original issue's description: > Put the BackgroundHTMLParser on oilpan heap > > This patch puts BackgroundHTMLParser on the oilpan heap, as well as > moving asynchrony logic to the BackgroundHTMLParser. > > BUG=689702 > > Review-Url: https://codereview.chromium.org/2683653004 > Cr-Commit-Position: refs/heads/master@{#450559} > Committed: https://chromium.googlesource.com/chromium/src/+/7fe94f0a7f3809fd93916c526d067dcb7f2b4ce3 TBR=yoav@yoav.ws,kouhei@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=689702, 692999 Review-Url: https://codereview.chromium.org/2695633007 Cr-Commit-Position: refs/heads/master@{#450997} Committed: https://chromium.googlesource.com/chromium/src/+/138a364d84e54ac2b6cc494a7245627745054341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -114 lines) Patch
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h View 9 chunks +24 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 13 chunks +55 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 9 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 29 chunks +95 lines, -37 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Charlie Harrison
Created Revert of Put the BackgroundHTMLParser on oilpan heap
3 years, 10 months ago (2017-02-16 15:15:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695633007/1
3 years, 10 months ago (2017-02-16 15:16:03 UTC) #3
Charlie Harrison
TBR yoav, kouhei
3 years, 10 months ago (2017-02-16 15:16:50 UTC) #5
Yoav Weiss
On 2017/02/16 15:16:50, Charlie Harrison wrote: > TBR yoav, kouhei LGTM to revert
3 years, 10 months ago (2017-02-16 16:27:52 UTC) #6
kouhei (in TOK)
lgtm
3 years, 10 months ago (2017-02-16 16:40:09 UTC) #7
kouhei (in TOK)
lgtm lgtm
3 years, 10 months ago (2017-02-16 16:40:10 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 17:07:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/138a364d84e54ac2b6cc494a7245...

Powered by Google App Engine
This is Rietveld 408576698