Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2695613002: Hide read-only volumes in "Save As" dialogs. (Closed)

Created:
3 years, 10 months ago by Shuhei Takahashi
Modified:
3 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide read-only volumes in "Save As" dialogs. BUG=chromium:690757 TEST=Save as dialog in Camera app does not show zip/media view volumes. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2695613002 Cr-Commit-Position: refs/heads/master@{#450247} Committed: https://chromium.googlesource.com/chromium/src/+/59a09c0b0ce14dd00ad1cfca4ecc37ce8f27b271

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -49 lines) Patch
M ui/file_manager/audio_player/js/audio_player.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 2 chunks +4 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js View 11 chunks +54 lines, -45 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
Shuhei Takahashi
fukino: PTAL
3 years, 10 months ago (2017-02-13 08:58:04 UTC) #11
fukino
lgtm
3 years, 10 months ago (2017-02-14 04:15:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695613002/20001
3 years, 10 months ago (2017-02-14 04:28:28 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 04:36:14 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/59a09c0b0ce14dd00ad1cfca4ecc...

Powered by Google App Engine
This is Rietveld 408576698