Replace OffscreenCanvasSurfaceClient with DisplayCompositorClient

Replace OffscreenCanvasSurfaceClient with DisplayCompositorClient

This is part of moving OffscreenCanvas into new display compositor.

BUG=686861, 664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2695603002
Cr-Commit-Position: refs/heads/master@{#450534}
Committed: https://chromium.googlesource.com/chromium/src/+/ac6bbf510624dc7116c6ad4ce489a42b9e6111aa

[xing.xu, 2017-02-13 07:26:32]

Description was changed from

==========
Replace OffscreenCanvasSurfaceClient with DisplayCompositorClient

This is part of moving OffscreenCanvas into new display compositor.

BUG=686861,664547
==========

to

==========
Replace OffscreenCanvasSurfaceClient with DisplayCompositorClient

This is part of moving OffscreenCanvas into new display compositor.

BUG=686861,664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[xing.xu, 2017-02-13 07:26:48]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 07:27:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-02-13 07:29:38]

Description was changed from

==========
Replace OffscreenCanvasSurfaceClient with DisplayCompositorClient

This is part of moving OffscreenCanvas into new display compositor.

BUG=686861,664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Replace OffscreenCanvasSurfaceClient with DisplayCompositorClient

This is part of moving OffscreenCanvas into new display compositor.

BUG=686861,664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[xing.xu, 2017-02-13 07:29:38]

xing.xu@intel.com changed reviewers:
+ blundell@chromium.org, fsamuel@chromium.org, jbauman@chromium.org,
junov@chromium.org, sadrul@chromium.org, xlai@chromium.org

[xing.xu, 2017-02-13 07:57:37]

PTAL.

[commit-bot: I haz the power, 2017-02-13 11:26:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 11:26:01]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-02-13 15:46:05]

This is awesome. Thanks for moving us in this direction. LGTM once
OffscreenCanvasSurfaceClient is deleted.

https://codereview.chromium.org/2695603002/diff/1/third_party/WebKit/public/p...
File
third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
(right):

https://codereview.chromium.org/2695603002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom:20:
interface OffscreenCanvasSurfaceClient {
Delete this?

[xing.xu, 2017-02-14 00:06:43]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[xing.xu, 2017-02-14 00:06:57]

On 2017/02/13 15:46:05, Fady Samuel wrote:
> This is awesome. Thanks for moving us in this direction. LGTM once
> OffscreenCanvasSurfaceClient is deleted.
> 
>
https://codereview.chromium.org/2695603002/diff/1/third_party/WebKit/public/p...
> File
>
third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
> (right):
> 
>
https://codereview.chromium.org/2695603002/diff/1/third_party/WebKit/public/p...
>
third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom:20:
> interface OffscreenCanvasSurfaceClient {
> Delete this?

Done, PTAL.

[commit-bot: I haz the power, 2017-02-14 00:08:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xlai (Olivia), 2017-02-14 02:01:36]

lgtm for offscreencanvas* with nits.

https://codereview.chromium.org/2695603002/diff/20001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
(right):

https://codereview.chromium.org/2695603002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom:12:
import "cc/ipc/surface_info.mojom";
Can you please take away surface_info here, since you no longer use it?

[xing.xu, 2017-02-14 02:12:53]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[xing.xu, 2017-02-14 02:13:09]

On 2017/02/14 02:01:36, xlai (Olivia) wrote:
> lgtm for offscreencanvas* with nits.
> 
>
https://codereview.chromium.org/2695603002/diff/20001/third_party/WebKit/publ...
> File
>
third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
> (right):
> 
>
https://codereview.chromium.org/2695603002/diff/20001/third_party/WebKit/publ...
>
third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom:12:
> import "cc/ipc/surface_info.mojom";
> Can you please take away surface_info here, since you no longer use it?

Done, PTAL.

[commit-bot: I haz the power, 2017-02-14 02:14:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 04:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 04:38:55]

Dry run: This issue passed the CQ dry run.

[xing.xu, 2017-02-14 04:49:21]

The CQ bit was checked by xing.xu@intel.com

[xing.xu, 2017-02-14 04:49:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, xlai@chromium.org
Link to the patchset: https://codereview.chromium.org/2695603002/#ps40001
(title: "Delete unused import surface_info")

[commit-bot: I haz the power, 2017-02-14 04:50:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 04:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 04:58:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xing.xu, 2017-02-14 05:01:30]

xing.xu@intel.com changed reviewers:
+ dcheng@chromium.org

[xing.xu, 2017-02-14 05:09:51]

xing.xu@intel.com changed reviewers:
+ ccameron@chromium.org

[xing.xu, 2017-02-14 05:22:30]

Hi, please help o review the following files:
Missing LGTM from an OWNER for these files:
    cc/ipc/BUILD.gn
    components/display_compositor/BUILD.gn
    services/ui/ws/BUILD.gn
    third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h
   
third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom

[dcheng, 2017-02-14 19:19:33]

mojom lgtm

[Justin Novosad, 2017-02-14 19:42:03]

lgtm

[Fady Samuel, 2017-02-14 19:44:40]

fsamuel@chromium.org changed reviewers:
+ danakj@chromium.org, sky@chromium.org
- blundell@chromium.org, ccameron@chromium.org

[Fady Samuel, 2017-02-14 19:44:40]

+danakj@ for components/display_compositor
+sky@ for services/ui/ws.

[sky, 2017-02-14 22:47:13]

LGTM

[danakj, 2017-02-14 22:54:22]

components/display_compositor rs LGTM

[xing.xu, 2017-02-14 23:59:56]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-02-15 00:00:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 01:12:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487116796266990,
"parent_rev": "886e1c8ecc4e7cfdf003f9dddbc0f0f05b8b9180", "commit_rev":
"ac6bbf510624dc7116c6ad4ce489a42b9e6111aa"}

[commit-bot: I haz the power, 2017-02-15 01:14:22]

Description was changed from

==========
Replace OffscreenCanvasSurfaceClient with DisplayCompositorClient

This is part of moving OffscreenCanvas into new display compositor.

BUG=686861,664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Replace OffscreenCanvasSurfaceClient with DisplayCompositorClient

This is part of moving OffscreenCanvas into new display compositor.

BUG=686861,664547
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2695603002
Cr-Commit-Position: refs/heads/master@{#450534}
Committed:
https://chromium.googlesource.com/chromium/src/+/ac6bbf510624dc7116c6ad4ce489...
==========

[commit-bot: I haz the power, 2017-02-15 01:14:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ac6bbf510624dc7116c6ad4ce489...

[perkj_chrome, 2017-02-15 12:56:46]

On 2017/02/15 01:14:24, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
>
https://chromium.googlesource.com/chromium/src/+/ac6bbf510624dc7116c6ad4ce489...

Can you please take a look at see if you cause 
webkit_tests flake in 

compositing/overflow/overflow-positioning.html
virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-positioning.html
to be flaky on win7? 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...

[xing.xu, 2017-02-16 07:51:37]

On 2017/02/15 12:56:46, perkj_chrome wrote:
> On 2017/02/15 01:14:24, commit-bot: I haz the power wrote:
> > Committed patchset #3 (id:40001) as
> >
>
https://chromium.googlesource.com/chromium/src/+/ac6bbf510624dc7116c6ad4ce489...
> 
> Can you please take a look at see if you cause 
> webkit_tests flake in 
> 
> compositing/overflow/overflow-positioning.html
>
virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-positioning.html
> to be flaky on win7? 
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...

This case fails before 9db26fbab2a06135a5519f21324d1a01851cef3d, before this
patch applied. 
BTW, this patch is only interface re-factor, not related any real logical of
composition.