Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2695593002: [promises] cleanup default promise handlers (Closed)

Created:
3 years, 10 months ago by gsathya
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] cleanup default promise handlers Use private symbols to mark default promise handler, instead of calling out to default handlers defined in JS. We check for this symbol in PromiseHandle and perform the appropriate behavior as the default handlers. Catch prediction logic is updated to account for a symbol. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2695593002 Cr-Commit-Position: refs/heads/master@{#43135} Committed: https://chromium.googlesource.com/v8/v8/+/31bc17f006f11e7699ff1f3ba86e3d580a707652

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : remove redundant check #

Patch Set 4 : remove unused var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -67 lines) Patch
M src/builtins/builtins-promise.cc View 1 2 3 4 chunks +47 lines, -14 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +36 lines, -34 lines 0 comments Download
M src/isolate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/js/promise.js View 1 2 chunks +0 lines, -13 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
gsathya
3 years, 10 months ago (2017-02-13 06:07:29 UTC) #10
Benedikt Meurer
Nice, LGTM!
3 years, 10 months ago (2017-02-13 06:09:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695593002/60001
3 years, 10 months ago (2017-02-13 06:29:32 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 06:31:18 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/31bc17f006f11e7699ff1f3ba86e3d580a7...

Powered by Google App Engine
This is Rietveld 408576698