Do not build share_service_impl and associated test on Mac/Android.

Do not build share_service_impl and associated test on Mac/Android.

These files are not used on those platforms and have a growing number of
conditional compilation statements which can be removed in a follow-up
CL.

BUG=668389
Review-Url: https://codereview.chromium.org/2695563002
Cr-Commit-Position: refs/heads/master@{#449905}
Committed: https://chromium.googlesource.com/chromium/src/+/33f13724ed6d1a1a56b0f112767e62c36824e377

[Matt Giuca, 2017-02-12 23:53:15]

mgiuca@chromium.org changed reviewers:
+ sammc@chromium.org

[Matt Giuca, 2017-02-12 23:53:16]

This should allow us to remove all the #if statements in share_service_impl and
unittest, as well as land https://crrev.com/2664033002/ as-is.

[Matt Giuca, 2017-02-12 23:53:49]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 23:53:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-02-13 00:27:33]

lgtm

https://codereview.chromium.org/2695563002/diff/20001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2695563002/diff/20001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:251: #if defined(OS_LINUX) ||
defined(OS_CHROMEOS) || defined(OS_WIN)
Can we remove the OS_CHROMEOS here? It would be nice if the ifdef exactly
matches the use rather than merely being identical in practice.

[Matt Giuca, 2017-02-13 00:32:42]

Tee hee, look at Reitveld's choice of diff range:
https://codereview.chromium.org/2695563002/diff/40001/chrome/browser/chrome_c...

https://codereview.chromium.org/2695563002/diff/20001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2695563002/diff/20001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:251: #if defined(OS_LINUX) ||
defined(OS_CHROMEOS) || defined(OS_WIN)
On 2017/02/13 00:27:33, Sam McNally wrote:
> Can we remove the OS_CHROMEOS here? It would be nice if the ifdef exactly
> matches the use rather than merely being identical in practice.

Done. (I thought about doing this but didn't want to make unrelated changes, but
yeah, it's for the best.)

[Matt Giuca, 2017-02-13 00:33:01]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2017-02-13 00:33:01]

The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org
Link to the patchset: https://codereview.chromium.org/2695563002/#ps40001
(title: "Remove redundant defined(OS_CHROMEOS).")

[commit-bot: I haz the power, 2017-02-13 00:33:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 00:34:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 00:34:42]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Matt Giuca, 2017-02-13 00:51:52]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2017-02-13 00:51:52]

The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org
Link to the patchset: https://codereview.chromium.org/2695563002/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-02-13 00:52:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 02:03:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486947112575520,
"parent_rev": "e0b2424b749ade8b4db00b003c17dcf4edac23b8", "commit_rev":
"33f13724ed6d1a1a56b0f112767e62c36824e377"}

[commit-bot: I haz the power, 2017-02-13 02:04:06]

Description was changed from

==========
Do not build share_service_impl and associated test on Mac/Android.

These files are not used on those platforms and have a growing number of
conditional compilation statements which can be removed in a follow-up
CL.

BUG=668389
==========

to

==========
Do not build share_service_impl and associated test on Mac/Android.

These files are not used on those platforms and have a growing number of
conditional compilation statements which can be removed in a follow-up
CL.

BUG=668389

Review-Url: https://codereview.chromium.org/2695563002
Cr-Commit-Position: refs/heads/master@{#449905}
Committed:
https://chromium.googlesource.com/chromium/src/+/33f13724ed6d1a1a56b0f112767e...
==========

[commit-bot: I haz the power, 2017-02-13 02:04:07]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/33f13724ed6d1a1a56b0f112767e...