Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2695553002: [turbofan] Add support for JSArrayBufferView intrinsics. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for JSArrayBufferView intrinsics. A couple of the builtins in src/js/typedarray.js still depends on these intrinsics, so if we don't want to regress all of them, we'll have to support these trivial intrinsics until the JS builtins are migrated. R=yangguo@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2695553002 Cr-Commit-Position: refs/heads/master@{#43130} Committed: https://chromium.googlesource.com/v8/v8/+/a8758ddb5c52eed092639413c492d6b26700a405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-12 18:32:48 UTC) #1
Yang
lgtm
3 years, 10 months ago (2017-02-12 18:59:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695553002/1
3 years, 10 months ago (2017-02-12 19:00:06 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-12 19:01:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a8758ddb5c52eed092639413c492d6b2670...

Powered by Google App Engine
This is Rietveld 408576698