Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 2695473002: Webapps: Clear AppBannerManagerAndroid::native_app_data_ prior to native app check (Closed)

Created:
3 years, 10 months ago by pkotwicz
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Webapps: Clear AppBannerManagerAndroid::native_app_data_ prior to native app check This CL fixes a bug where 1) Navigating to a web page which has a Web Manifest with "related_applications" specified. 2) Navigating to a web page with a web app compatible Web Manifest would show a native app banner for the second page. Whether |AppBannerManagerAndroid::native_app_data_| is set is used to determine which type of banner to create (native app or webapp). Previously |AppBannerManagerAndroid::native_app_data_| was only cleared if there was a native app associated with the Web Manifest. This CL clears |AppBannerManagerAndroid::native_app_data_| prior to checking whether there is a native app associated with the Web Manifest. BUG=687024 Review-Url: https://codereview.chromium.org/2671653002 Cr-Commit-Position: refs/heads/master@{#448218} (cherry picked from commit de6f8b587176d94643869d0f28aee52b92ad00b8) Review-Url: https://codereview.chromium.org/2695473002 . Cr-Commit-Position: refs/branch-heads/2987@{#452} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/6403b796f661a1dbf0daf3825ff737d366ddea7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M chrome/browser/android/banners/app_banner_manager_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/banners/app_banner_manager_android.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/banners/app_banner_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/banners/app_banner_manager.cc View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pkotwicz
3 years, 10 months ago (2017-02-10 21:16:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6403b796f661a1dbf0daf3825ff737d366ddea7f.

Powered by Google App Engine
This is Rietveld 408576698