Chromium Code Reviews
DescriptionWebapps: Clear AppBannerManagerAndroid::native_app_data_ prior to native app check
This CL fixes a bug where
1) Navigating to a web page which has a Web Manifest with
"related_applications" specified.
2) Navigating to a web page with a web app compatible Web Manifest
would show a native app banner for the second page.
Whether |AppBannerManagerAndroid::native_app_data_| is set is used to determine
which type of banner to create (native app or webapp). Previously
|AppBannerManagerAndroid::native_app_data_| was only cleared if there was a
native app associated with the Web Manifest. This CL clears
|AppBannerManagerAndroid::native_app_data_| prior to checking
whether there is a native app associated with the Web Manifest.
BUG=687024
Review-Url: https://codereview.chromium.org/2671653002
Cr-Commit-Position: refs/heads/master@{#448218}
(cherry picked from commit de6f8b587176d94643869d0f28aee52b92ad00b8)
Review-Url: https://codereview.chromium.org/2695473002 .
Cr-Commit-Position: refs/branch-heads/2987@{#452}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/6403b796f661a1dbf0daf3825ff737d366ddea7f
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||