Web MIDI: make input_ports_ and output_ports_ members private

media/midi/midi_manager.h

Index: media/midi/midi_manager.h
diff --git a/media/midi/midi_manager.h b/media/midi/midi_manager.h
index 46602c1df16bef9d293e99808bf81ec7747bb106..82a603b4f03f814c3b4ca94a5fce178dbf705e2e 100644
--- a/media/midi/midi_manager.h
+++ b/media/midi/midi_manager.h
@@ -91,12 +91,12 @@ class MEDIA_EXPORT MidiManager {
   // input_ports() is a list of MIDI ports for receiving MIDI data.
   // Each individual port in this list can be identified by its
   // integer index into this list.
-  const MidiPortInfoList& input_ports() { return input_ports_; }
+  const MidiPortInfoList& get_input_ports() { return input_ports_; }

[yukawa, 2014/05/07 00:29:57]

... const { ... }

BTW, |input_ports()| seems to be recommended in Google C++ style. 
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml

| Accessors and mutators (get and set functions) should match
| the name of the variable they are getting and setting.

Anyway, I don't have strong opinion here. Just FYI.

[Takashi Toyoshima, 2014/05/07 02:28:26]

Oh, that's misunderstanding. Fixed.

 
   // output_ports() is a list of MIDI ports for sending MIDI data.
   // Each individual port in this list can be identified by its
   // integer index into this list.
-  const MidiPortInfoList& output_ports() { return output_ports_; }
+  const MidiPortInfoList& get_output_ports() { return output_ports_; }

[yukawa, 2014/05/07 00:29:57]

... const { }

[Takashi Toyoshima, 2014/05/07 02:28:26]

Thanks for catching them. I'm relatively lazy to find out const points, so these
comments are useful.

 
  protected:
   friend class MidiManagerUsb;
@@ -120,6 +120,7 @@ class MEDIA_EXPORT MidiManager {
 
   void AddInputPort(const MidiPortInfo& info);
   void AddOutputPort(const MidiPortInfo& info);
+  void ClearInputOutputPorts();
 
   // Dispatches to all clients.
   // TODO(toyoshim): Fix the mac implementation to use
@@ -142,10 +143,6 @@ class MEDIA_EXPORT MidiManager {
     return pending_clients_.size();
   }
 
-  // TODO(toyoshim): Make |input_ports_| and |output_ports_| private members.
-  MidiPortInfoList input_ports_;
-  MidiPortInfoList output_ports_;
-
  private:
   void CompleteInitializationInternal(MidiResult result);
 
@@ -172,6 +169,9 @@ class MEDIA_EXPORT MidiManager {
   // |result_|.
   base::Lock lock_;
 
+  MidiPortInfoList input_ports_;
+  MidiPortInfoList output_ports_;
+
   DISALLOW_COPY_AND_ASSIGN(MidiManager);
 };